Closed
Bug 1436721
Opened 6 years ago
Closed 6 years ago
Turn off TestStandardURL * tests on automation
Categories
(Core :: Networking, enhancement, P5)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: igoldan, Assigned: jmaher)
Details
(Whiteboard: [necko-triaged][PI:February])
Attachments
(1 file, 1 obsolete file)
|
2.72 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
Namely, these tests are: - NormalizePerf - NormalizePerfFails - Perf
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Component: Perfherder → Networking
Product: Tree Management → Core
Version: --- → unspecified
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [PI:February]
|
||
Updated•6 years ago
|
Priority: -- → P5
Whiteboard: [PI:February] → [necko-triaged][PI:February]
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8949355 [details] [diff] [review] remove gtest_bench tests from testStandardUrl.cpp Review of attachment 8949355 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch. We indeed want to disable the tests on automation, but I would like to keep the code to be run locally if needed. You can just disable the tests like so: https://searchfox.org/mozilla-central/rev/a539f8f7fe288d0b4d8d6a32510be20f52bb7a0f/media/libcubeb/gtest/test_resampler.cpp#424
Attachment #8949355 -
Flags: review?(valentin.gosu) → review-
|
|
Assignee | |
Comment 3•6 years ago
|
||
thanks for the tip, this seems to work based on try, waiting on windows/osx for final validation.
Attachment #8949355 -
Attachment is obsolete: true
Attachment #8949399 -
Flags: review?(valentin.gosu)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8949399 [details] [diff] [review] remove gtest_bench tests from testStandardUrl.cpp Review of attachment 8949399 [details] [diff] [review]: ----------------------------------------------------------------- Thanks a lot!
Attachment #8949399 -
Flags: review?(valentin.gosu) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dd69f6f9bcd0 Turn off TestStandardURL * tests on automation. r=rwood
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dd69f6f9bcd0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•