Closed
Bug 1436792
Opened 6 years ago
Closed 6 years ago
IOError running py-compat linters on Windows
Categories
(Developer Infrastructure :: Lint and Formatting, enhancement, P1)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
Details
Attachments
(2 files)
The py-compat linters save file paths to a temporary file (which then gets read by check_compat.py). Looks like there's a bug on Windows, think we have to use mozfile.NamedTemporaryFile instead of tempfile.NamedTemporaryFile.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8949516 [details] Bug 1436792 - [py-compat] Improve error messaging when python is missing, https://reviewboard.mozilla.org/r/218854/#review224606 thanks for good comments and cleaning up the output
Attachment #8949516 -
Flags: review?(jmaher) → review+
|
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8949517 [details] Bug 1436792 - [py-compat] Fix issue opening the temporary manifest on Windows, https://reviewboard.mozilla.org/r/218856/#review224608 excellent
Attachment #8949517 -
Flags: review?(jmaher) → review+
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3ddf5e47032 [py-compat] Improve error messaging when python is missing, r=jmaher https://hg.mozilla.org/integration/autoland/rev/4b66e3729eda [py-compat] Fix issue opening the temporary manifest on Windows, r=jmaher
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a3ddf5e47032 https://hg.mozilla.org/mozilla-central/rev/4b66e3729eda
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•6 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•5 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•