1436806 - Lift subdirectory restriction for try pushes by wptsync user

Status: RESOLVED FIXED

(Developer Services :: General, task)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

We have a conditional go-ahead from :hwine to allow any/all file changes by [e-mail] on try.

Excerpts from original emails for context:

-On Thu, Feb 8, 2018 at 9:06 AM, Maja Frydrychowicz <[e-mail]> wrote:
We'd like to allow wptsync to push files outside of testing/web-platform to try. Namely, configuration files like try_task_config.json and taskcluster/ci/config.yml which allow us to control scheduling more specifically than with try syntax alone. For example, we'd like to modify the config.yml on our try pushes to turn off some unnecessary long running "ride-along" builds.

Rather than asking for permission for individual files/dirs, I wonder if it's adequately safe to just allow all changes by wptsync on try.

-On Thu, Feb 8, 2018 at 1:46 PM, Hal Wine <[e-mail]> wrote:
My only concern about allowing "anything on try" is adding complexity to the existing hook. Complexity can be brittle :(

That said, it's a reasonable request. Let's track the work via a bug, and ensure that gps approves the change.

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: hghooks: lift subdirectory restriction for try pushes by wptsync user (bug 1436806);

Review commit: https://reviewboard.mozilla.org/r/218860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218860/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8949515 [details]
hghooks: lift subdirectory restriction for try pushes by wptsync user (bug 1436806);

https://reviewboard.mozilla.org/r/218860/#review224612

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/5ef6e760c5ae
hghooks: lift subdirectory restriction for try pushes by wptsync user ; r=gps