Open Bug 1436834 Opened 4 years ago Updated 3 years ago

Use a separate event target for docgroups

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

Tracking Status
firefox60 --- affected

People

(Reporter: jdm, Unassigned)

Details

Attachments

(1 file)

Currenltly DocGroup::EventTargetFor delegates to TabGroup::EventTargetFor. This means that bug 1436743 and bug 1436742 are less effective than they could be, because they only recognize events that are dispatched directly to the docgroup. I have a patch that I'm rebasing that adds a separate event target for the docgroup so the events dispatched to the event target are charged to the docgroup as expected.
Assignee: nobody → josh
Status: NEW → ASSIGNED
This is all very liberally copied and modified from SchedulerGroup's implementation. If there's a better way to share the code, I'm open to it.
Try build for just this patch in particular suggests I need to spend some time chasing leaks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb13a119dc22c668d7692dc418bdff56272cf728
Comment on attachment 8949537 [details] [diff] [review]
Give docgroups event targets indepedent of their associated tabgroups

Review of attachment 8949537 [details] [diff] [review]:
-----------------------------------------------------------------

I think a better approach here would probably be to make DocGroup inherit from SchedulerGroup - it seems like it'd be cleaner, and it would help with avoiding unnecessary code duplication.
Attachment #8949537 - Flags: review?(nika) → review-
Priority: -- → P2
Realistically I am not working on this. The better approach from comment 5 was not straightforward, so I moved on to other things.
Assignee: josh → nobody
Status: ASSIGNED → NEW
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.