1436834 - Use a separate event target for docgroups

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Josh Matthews [:jdm]]

Currenltly DocGroup::EventTargetFor delegates to TabGroup::EventTargetFor. This means that bug 1436743 and bug 1436742 are less effective than they could be, because they only recognize events that are dispatched directly to the docgroup. I have a patch that I'm rebasing that adds a separate event target for the docgroup so the events dispatched to the event target are charged to the docgroup as expected.

Comment 1

[Josh Matthews [:jdm]]

Attachment: Give docgroups event targets indepedent of their associated tabgroups

Comment 2

[Josh Matthews [:jdm]]

This is all very liberally copied and modified from SchedulerGroup's implementation. If there's a better way to share the code, I'm open to it.

Comment 3

[Josh Matthews [:jdm]]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f86cca972c3a78ea980642940f43582e25c574b

Comment 4

[Josh Matthews [:jdm]]

Try build for just this patch in particular suggests I need to spend some time chasing leaks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb13a119dc22c668d7692dc418bdff56272cf728

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8949537 [details] [diff] [review]
Give docgroups event targets indepedent of their associated tabgroups

Review of attachment 8949537 [details] [diff] [review]:
-----------------------------------------------------------------

I think a better approach here would probably be to make DocGroup inherit from SchedulerGroup - it seems like it'd be cleaner, and it would help with avoiding unnecessary code duplication.

Comment 6

[Josh Matthews [:jdm]]

Realistically I am not working on this. The better approach from comment 5 was not straightforward, so I moved on to other things.