Status

()

enhancement
RESOLVED FIXED
a year ago
2 months ago

People

(Reporter: adrian17, Assigned: adrian17)

Tracking

(Blocks 1 bug)

unspecified
mozilla60
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(1 attachment)

Almost empty, one implementation, unused in mozilla-central and comm-central.
Assignee

Updated

a year ago
Assignee: nobody → adrian.wielgosik
Blocks: 1387169
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

https://reviewboard.mozilla.org/r/218924/#review224654


Code analysis found 5 defects in this patch:
 - 5 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.cpp:32
(Diff revision 1)
>  NS_IMPL_CYCLE_COLLECTING_ADDREF(Crypto)
>  NS_IMPL_CYCLE_COLLECTING_RELEASE(Crypto)
>  
>  NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(Crypto, mParent, mSubtle)
>  
> -Crypto::Crypto()
> +Crypto::Crypto(nsIGlobalObject* aParent)

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

https://reviewboard.mozilla.org/r/218924/#review224706
Attachment #8949564 - Flags: review?(bzbarsky) → review+

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c3d64a657a71
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.