Closed Bug 1436865 Opened 3 years ago Closed 2 years ago

Remove nsIDOMCrypto

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: adrian17, Assigned: adrian17)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Almost empty, one implementation, unused in mozilla-central and comm-central.
Assignee: nobody → adrian.wielgosik
Blocks: 1387169
Status: NEW → ASSIGNED
Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

https://reviewboard.mozilla.org/r/218924/#review224654


Code analysis found 5 defects in this patch:
 - 5 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.cpp:32
(Diff revision 1)
>  NS_IMPL_CYCLE_COLLECTING_ADDREF(Crypto)
>  NS_IMPL_CYCLE_COLLECTING_RELEASE(Crypto)
>  
>  NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(Crypto, mParent, mSubtle)
>  
> -Crypto::Crypto()
> +Crypto::Crypto(nsIGlobalObject* aParent)

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]
Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

https://reviewboard.mozilla.org/r/218924/#review224706
Attachment #8949564 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/c3d64a657a71
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.