1436865 - Remove nsIDOMCrypto

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Adrian Wielgosik [:adrian17]]

Almost empty, one implementation, unused in mozilla-central and comm-central.

Comment 1

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1436865 - Remove nsIDOMCrypto.

Review commit: https://reviewboard.mozilla.org/r/218924/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218924/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

https://reviewboard.mozilla.org/r/218924/#review224654


Code analysis found 5 defects in this patch:
 - 5 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.h:28
(Diff revision 1)
>  {
>  protected:
>    virtual ~Crypto();
>  
>  public:
> -  Crypto();
> +  Crypto(nsIGlobalObject* aParent);

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

::: dom/base/Crypto.cpp:32
(Diff revision 1)
>  NS_IMPL_CYCLE_COLLECTING_ADDREF(Crypto)
>  NS_IMPL_CYCLE_COLLECTING_RELEASE(Crypto)
>  
>  NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(Crypto, mParent, mSubtle)
>  
> -Crypto::Crypto()
> +Crypto::Crypto(nsIGlobalObject* aParent)

Error: Bad implicit conversion constructor for 'crypto' [clang-tidy: mozilla-implicit-constructor]

Comment 3

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218924/diff/1-2/

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8949564 [details]
Bug 1436865 - Remove nsIDOMCrypto.

https://reviewboard.mozilla.org/r/218924/#review224706

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d64a657a71
Remove nsIDOMCrypto. r=bz

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/c3d64a657a71