Closed Bug 1436908 Opened 2 years ago Closed 2 years ago

Fix EGLSurface leak at RenderCompositorANGLE

Categories

(Core :: Graphics: WebRender, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

RenderCompositorANGLE::Destroy() is implemented, but it is not called correctly. It seems to better to call DestroyEGLSurface() in RenderCompositorANGLE::~RenderCompositorANGLE() instead.
Assignee: nobody → sotaro.ikeda.g
Summary: Remove RenderCompositorANGLE::Destroy() → Fix EGLSurface leak at RenderCompositorANGLE
Comment on attachment 8949635 [details] [diff] [review]
patch - Fix EGLSurface leak at RenderCompositorANGLE

The patch actually fixing the leak. Removing Destroy()s are just a side effect.
Attachment #8949635 - Attachment description: patch - Remove RenderCompositorANGLE::Destroy() → patch - Fix EGLSurface leak at RenderCompositorANGLE
Attachment #8949635 - Flags: review?(nical.bugzilla)
Attachment #8949635 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/209ac1955df7
Fix EGLSurface leak at RenderCompositorANGLE r=nical
https://hg.mozilla.org/mozilla-central/rev/209ac1955df7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.