1436943 - Login fails with "Unrecognized identity" when using Google authentication

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I tried to login to Treeherder by using my mozilla.com address and the Google authentication. But I always get a failure with the message "Unrecognized identity".

As Ed pointed out on IRC this comes from:

https://github.com/mozilla/treeherder/blob/e61f356d2d02d83333af37ab7292e68a5c75d43e/treeherder/auth/backends.py#L70-L77

Comment 1

[Ed Morley [:emorley]]

Henrik reported on IRC that after switching to LDAP things worked.

It seems like we could perhaps:
* adjust the exception linked above to mention the name of the identity, to assist debugging (these exceptions appear in New Relic)
* improve the way the login callback page displays errors returned from /api/auth/login/
* fix Google logins if they are expected to work, or else remove google from the list of choices offered

Additional context from IRC:

08:44 <whimboo> since the last TH upgrade i have issues logging in
08:44 <whimboo> with my mozilla.com account
08:44 <whimboo> I always get: Unrecognized identity
08:44 <whimboo> not sure what that means
08:45 <whimboo> it's just a blank page

Comment 2

[Hassan Ali (:hassan)]

https://github.com/mozilla/treeherder/pull/3210.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a74003f41b38d8d5198db7dfab056fbe19133d75
Bug 1436943 - Login fails with "Unrecognized identity" when using Google authentication (#3210)

* Allow Google login

Presently, when you login with google you are prompted with a screen
that tells you to login using another provider. However, if you try to
login with google using an LDAP email "@mozilla.com", then there is a
blank page saying Unrecognized identity.

* Add test cases

Comment 4

[Ed Morley [:emorley]]

This is now deployed to stage - could you try logging in there with Google and seeing what happens?
https://treeherder.allizom.org/

Comment 5

[Ed Morley [:emorley]]

This worked for me on stage using the Google login option with my @mozilla.com address, so I've deployed it to production too.

Marking bug as fixed, but leaving needinfo to confirm works for you too :-)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, it works. Thanks