1436944 - Crash in vrclient_x64.dll@0x96583

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-357ab65b-f75d-4f41-9a0d-358e70180208.
=============================================================

Top 4 frames of crashing thread:

0 vrclient_x64.dll vrclient_x64.dll@0x96583 
1 vrclient_x64.dll vrclient_x64.dll@0x21eb0f 
2 vrclient_x64.dll vrclient_x64.dll@0x69dc1 
3 vrclient_x64.dll vrclient_x64.dll@0x21eb2f 

=============================================================

There are 160 crashes with signature "vrclient_x64.dll@[0-9a-f]+" in nightly 60.
There was a spike the 2018-02-08: 130 crashes just this day with a lot of different buildids so probably they're due to an update of a dll.

:kip, could you investigate please ?

Comment 1

[:kip (Kearwood Gilbert)]

Some initial observations:

vrclient_x64.dll is part of the SteamVR runtime, most often associated with the HTC Vive.

On January 29, there was an updated NVidia Geforce driver.  Updating the driver while WebVR is active will cause a context loss, which we may not be handling gracefully during WebVR sessions.

On January 25, SteamVR's release channel was updated, near the peak of the reports.

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Kip, when you get a chance, could you take a look to see if anything's changed here? Thanks!

Comment 4

[:kip (Kearwood Gilbert)]

I suspect we can prevent a category of these crashes that happen especially during driver updates by handling device context loss better.

I'll run through some sites on current drivers with our OpenVR supported devices and see if I can reproduce any crashes.

Comment 5

[:kip (Kearwood Gilbert)]

Bug 1462695 indicates that if we induce a context loss, we hit a different crash signature.  This case has been fixed in Bug 1462695.

Comment 6

[:kip (Kearwood Gilbert)]

On the Feb 8, 2018 spike of these reports, many Firefox buildid's were impacted on a variety of GPU driver versions.

The vrclient_x64.dll signature (447F1F25CD28411BBE9293B92B4F67D11) was consistent in all of the crashes, including those before and after the spike.  The vrclient_x64.dll file is updated with each release of SteamVR.

Perhaps we could conclude that a particular SteamVR update was at fault and that except for two isolated incidences (both of which used the same, old, SteamVR client version), is no longer crashing with this signature.

Could we resolve this bug based on this info?

Comment 7

[Calixte Denizet (:calixte)]

:kip, ok let's dot that.