1436951 - Warnings: '!mOffset.value()' (EditorDOMPoint.h, line 499)

Status: NEW

(Core :: DOM: Editor, enhancement, P3)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1436216 +++

+++ This bug was initially created as a clone of Bug #1434969 +++

As per bug 1434969 comment #24, we see this eight times in our Mozmill test suite,
https://public-artifacts.taskcluster.net/E6nU2e8FQ4SvbCxgyY6Cog/0/public/logs/live_backing.log
in one of our tests: cloudfile\test-cloudfile-notifications.js. That one does a bit of editing.

I'll get a stack once I've compiled with the changes from bug 1436216.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yeah, I was investigating it. However, it occurs when HTMLEditRules::PromoteRange() calls RewindOffset(). However, I still don't understand why it needs to call RewindOffset() and what's the expected result when it already refers start of the container.

Comment 2

[Jorg K (CEST = GMT+2)]

I added a MOZ_ASSERT() and got this:

Assertion failure: mOffset.value(), at c:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\include\mozilla/EditorDOMPoint.h:499
#01: mozilla::EditorDOMPointBase<nsINode *,nsIContent *>::RewindOffset (c:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\include\mozilla\editordompoint.h:497)
#02: mozilla::HTMLEditRules::PromoteRange (c:\mozilla-source\comm-central\mozilla\editor\libeditor\htmleditrules.cpp:6075)
#03: mozilla::HTMLEditRules::AfterEditInner (c:\mozilla-source\comm-central\mozilla\editor\libeditor\htmleditrules.cpp:478)
#04: mozilla::HTMLEditRules::AfterEdit (c:\mozilla-source\comm-central\mozilla\editor\libeditor\htmleditrules.cpp:416)
#05: mozilla::HTMLEditor::EndOperation (c:\mozilla-source\comm-central\mozilla\editor\libeditor\htmleditor.cpp:3333)
#06: mozilla::AutoRules::~AutoRules (c:\mozilla-source\comm-central\obj-i686-pc-mingw32\dist\include\mozilla\editorutils.h:397)
#07: _NS_InvokeByIndex (c:\mozilla-source\comm-central\mozilla\xpcom\reflect\xptcall\md\win32\xptcinvoke_asm_x86_msvc.asm:57)
#08: CallMethodHelper::Invoke (c:\mozilla-source\comm-central\mozilla\js\xpconnect\src\xpcwrappednative.cpp:1948)

As you said, it comes from HTMLEditRules::PromoteRange().