1436977 - Funsize is slower for MacOSX

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Simon Fraser [:sfraser] ⌚️GMT]

It seems that files in Mac packages are altered when they are signed

Unpacked from the nightly build's dmg files:
0bc1ba87b2899edc30aa93db783cadc0357ae6bc  ./zh-CN/Firefox Nightly/Firefox Nightly.app/Contents/MacOS/XUL
0bc1ba87b2899edc30aa93db783cadc0357ae6bc  ./zh-TW/Firefox Nightly/Firefox Nightly.app/Contents/MacOS/XUL
0bc1ba87b2899edc30aa93db783cadc0357ae6bc  ./wo/Firefox Nightly/Firefox Nightly.app/Contents/MacOS/XUL

On signing they're returned as .tar.gz, and now:

19120dc96803ca8c14a821b4691f8ecc636ef045  ./zh-CN/Firefox Nightly.app/Contents/MacOS/XUL
c1890c355d20aeddbf59fd321a427c000601fa54  ./zh-TW/Firefox Nightly.app/Contents/MacOS/XUL
fec2f0f6f8b0ebc99900c4b55a9451bca6588d38  ./wo/Firefox Nightly.app/Contents/MacOS/XUL

This means that the S3 caching is not working for Macs, as the larger files are all different.

We should 
1. add some data collection about cache hits/misses
2. turn off s3 caching for macs
3. Turn off caching for small files on other platforms - trading 1-2s of cpu for 1-2s of network latency is likely not buying us much.

Comment 1

[Chris AtLee [:catlee]]

IIRC, signing on OSX modifies the binaries to include references to the app signature manifest. The contents of the signature manifest will be different due to localization, therefore the reference inside XUL will be different.

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

Graphs are noisy with the cache hit/miss, I'm going to turn off the caching for the smaller files, where it doesn't benefit us.

An 'aws s3 ls foo' takes ~0.7s, and a copy about the same length of time, but an mbsdiff on files of less than about 1Mb uses less time.

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1436977 Disable partials diff caching for macosx

Review commit: https://reviewboard.mozilla.org/r/219818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219818/

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8950537 [details]
Bug 1436977 Disable partials diff caching for macosx

https://reviewboard.mozilla.org/r/219818/#review225652

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24cd8e6e5b2a
Disable partials diff caching for macosx r=rail

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/24cd8e6e5b2a