Closed Bug 1437028 Opened 3 years ago Closed 3 years ago

DAMP fails on the new Win 10 talos (tc) hardware

Categories

(Testing :: Talos, defect)

Version 3
defect
Not set
normal

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: rwood, Assigned: rwood)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Consistently fails at 'complicated.netmonitor', so disable that part of DAMP on Windows.
Blocks: 1431161
Comment on attachment 8949735 [details]
Bug 1437028 - Disable DAMP's complicated.netmonitor on Win;

https://reviewboard.mozilla.org/r/219052/#review225226

That's really sad to have to disable a test like this.
It highlights the need of talos.ini or damp.ini, like other test suites.
These files help disable one test only on same environment.

Is it easier to disable some other Talos subtests?
Attachment #8949735 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #3)
> Comment on attachment 8949735 [details]
> Bug 1437028 - Disable DAMP's complicated.netmonitor on Win;
> 
> https://reviewboard.mozilla.org/r/219052/#review225226
> 
> That's really sad to have to disable a test like this.
> It highlights the need of talos.ini or damp.ini, like other test suites.
> These files help disable one test only on same environment.
> 
> Is it easier to disable some other Talos subtests?

Thanks Alexandre, yes it's defintely not ideal. No other talos tests are the same however it's very rare for subtests to be disabled/enabled.
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d4283f23786
Disable DAMP's complicated.netmonitor on Win; r=ochameau
https://hg.mozilla.org/mozilla-central/rev/0d4283f23786
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
This updated our DAMP baselines:

== Change summary for alert #11555 (as of Wed, 14 Feb 2018 13:07:30 GMT) ==

Improvements:

  6%  damp windows10-64 pgo e10s stylo     73.63 -> 69.30
  4%  damp windows7-32 pgo e10s stylo      74.87 -> 72.23

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11555
You need to log in before you can comment on or make changes to this bug.