Closed
Bug 1437045
Opened 6 years ago
Closed 6 years ago
[wpt-sync] PR 9442 - [LayoutNG] Improve min/max calculation wrt. floats.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
Details
(Whiteboard: [wptsync downstream])
The presence of floats complicate min/max intrinsic inline size calculation. They affect lines and child blocks in the same block formatting context. Therefore, when calculating min/max sizes of a child, we need to pass along information about floats adjacent to the current "virtual" block position. This change actually makes NG slightly "better" than legacy Blink layout, Edge and Firefox. This may be an issue for compatibility. It should be fairly easy to "dumb down" the machinery to be compatible with the others, though, if this should become an issue. Two tests regressed because of this. Reported bug 810370. This change also caused grid-item-margins-not-collapse-expected.html to make room for the floats to fit beside each other, so I modified it. Also removed bogus "margin" attributes. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I59730d7333fa7699a42ab93d2c4674c267d834aa Reviewed-on: https://chromium-review.googlesource.com/908753 WPT-Export-Revision: 5845787afb710b5553139203aa889bd4e1ae5a99
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7906ecc99ea7cf6c8c0d49b4882002fbcfc120b
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c335c1ae65aeffefd8e370ee7a79056d7a99663
Reporter | ||
Comment 3•6 years ago
|
||
Ran 1 tests PASS : 1
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/8263aedb061d [wpt PR 9442] - [LayoutNG] Improve min/max calculation wrt. floats., a=testonly
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8263aedb061d
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•