Closed Bug 1437046 Opened 2 years ago Closed 2 years ago

[wpt-sync] PR 9444 - Skip pushing invalidation sets inside subtree changes.

Categories

(Core :: DOM: CSS Object Model, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

Details

(Whiteboard: [wptsync downstream])

We already skipped pushing invalidation sets for InvalidateChildren, but
InvalidateShadowRootChildren() didn't have this check causing a DCHECK
failure in StyleInvalidator::Invalidate().

Bug: 809270
Change-Id: Id4634be04a036b5056567d581f8a1c5cc630d88c
Reviewed-on: https://chromium-review.googlesource.com/908751
WPT-Export-Revision: f6b3ec776d6fbc47f373976adc78ffdefe5e8862
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1

These new tests don't PASS on all platforms
/css/cssom/selectorText-modification-restyle-002.html
    CSSOM: Modify selectorText in a shadow tree stylesheet: FAIL
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8218358455aa
[wpt PR 9444] - Skip pushing invalidation sets inside subtree changes., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb510e6b73a0
[wpt PR 9444]- Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/8218358455aa
https://hg.mozilla.org/mozilla-central/rev/fb510e6b73a0
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.