Closed Bug 1437061 Opened 6 years ago Closed 6 years ago

[wpt-sync] PR 9445 - [css-grid] Apply automatic minimum size clamping to spanning items too

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

Details

(Whiteboard: [wptsync downstream]) 

In r783213 we added the conditions from the spec to apply
the automatic minimum size clamping when required
but only to non-spanning items.
See: https://drafts.csswg.org/css-grid/#min-size-auto

This patch moves the code from GridTrackSizingAlgorithm::SizeTrackToFitNonSpanningItem()
to GridTrackSizingAlgorithmStrategy::MinSizeForChild()
that way the clamping is applied for both spanning and non-spanning items.

This somehow reverts r783213, as it was adding some duplicated code.
All the checks to know if we should use that part of the spec
were already present in GridTrackSizingAlgorithmStrategy::MinSizeForChild().

Apart from using the previous code, there's a new loop to verify
that the max track sizing function is fixed for all the tracks of the item.

BUG=809005
TEST=external/wpt/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html
TEST=external/wpt/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html

Change-Id: I919a83d152d8263251d3211dd5ebf175f7cf9717

Reviewed-on: https://chromium-review.googlesource.com/910049
WPT-Export-Revision: 3319bfcd40af461e689a0d9ffc044865526cd764
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
[ Triage 2017/02/20: P3 ]
Priority: -- → P3
Ran 4 tests and 210 subtests
OK     : 4
PASS   : 210
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80388e3c9696
[wpt PR 9445] - [css-grid] Apply automatic minimum size clamping to spanning items too, a=testonly
https://hg.mozilla.org/mozilla-central/rev/80388e3c9696
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.