1437070 - Some "health" pings report an undefined "sendFailure" reason

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Alessio Placitelli [:Dexter]]

Some health pings sent on January from Release and Nightly, on my machine, are reporting "undefined" as the send failure type. See below for a sample payload:

> {
>   "os": {
>     "name": "WINNT",
>     "version": "10.0"
>   },
>   "reason": "shutdown",
>   "sendFailure": {
>     "undefined": 4
>   }
> }

Comment 1

[Chris H-C :chutten]

It seems as though bug 1400748 added a new ErrorType "eTerminated" to C++[1], but we didn't mirror it in TelemetrySend's XHR_ERROR_TYPE enum or TELEMETRY_SEND_FAILURE_TYPE's labels. 

Maybe the "undefined"s correspond to that value?

[1]: https://searchfox.org/mozilla-central/rev/a5abf843f8fac8530aa5de6fb40e16547bb4a47a/dom/xhr/XMLHttpRequestMainThread.h#196

Comment 2

[Chris H-C :chutten]

Fork a mentored bug for adding the new label, then this bug will be about analysing the result to see if the new label fixes it.

Comment 3

[Chris H-C :chutten]

https://sql.telemetry.mozilla.org/queries/52381/source#139602 shows that undefined is replaced with eTimeout as soon as bug 1442700 landed.

Case closed: it was eTerminated the whole time.