enforce success of NSS_Shutdown in debug, non-android builds

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: keeler, Assigned: keeler)

Tracking

(Depends on 1 bug)

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 attachment)

In bug 1417680 NSS_Shutdown was moved to ShutdownXPCOM. Right now it just emits an error to the terminal if it fails. We should see if we can enforce that it succeeds in debug builds (or where gShutdownChecks is not none), which should protect against regressing leaking NSS resources.
It looks like I've found all of the debug, non-android leaks, so I'm going to start with that and hopefully add in android as well later.
Assignee: nobody → dkeeler
Priority: P2 → P1
Summary: enforce success of NSS_Shutdown in debug builds (and/or according to e.g. gShutdownChecks) → enforce success of NSS_Shutdown in debug, non-android builds
Whiteboard: [psm-assigned]
Comment on attachment 8960387 [details] [diff] [review]
patch

Review of attachment 8960387 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the follow up. Should we file a separate bug for android or just keep this open?
Attachment #8960387 - Flags: review?(erahm) → review+
Thanks! I filed bug 1447363 to figure out what's leaking on android. If that's relatively straightforward we can add this assertion to android builds when we fix that.
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/faa9d965f89e
enforce that NSS_Shutdown succeeds on debug, non-android platforms (to prevent NSS resource leaks) r=erahm
https://hg.mozilla.org/mozilla-central/rev/faa9d965f89e
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.