Closed
Bug 1437128
Opened 6 years ago
Closed 6 years ago
enforce success of NSS_Shutdown in debug, non-android builds
Categories
(Core :: Security: PSM, enhancement, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
(Depends on 1 open bug)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
|
1.99 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
In bug 1417680 NSS_Shutdown was moved to ShutdownXPCOM. Right now it just emits an error to the terminal if it fails. We should see if we can enforce that it succeeds in debug builds (or where gShutdownChecks is not none), which should protect against regressing leaking NSS resources.
|
Assignee | |
Comment 1•6 years ago
|
||
It looks like I've found all of the debug, non-android leaks, so I'm going to start with that and hopefully add in android as well later.
Assignee: nobody → dkeeler
Priority: P2 → P1
Summary: enforce success of NSS_Shutdown in debug builds (and/or according to e.g. gShutdownChecks) → enforce success of NSS_Shutdown in debug, non-android builds
Whiteboard: [psm-assigned]
|
|
Assignee | |
Comment 2•6 years ago
|
||
Attachment #8960387 -
Flags: review?(erahm)
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8960387 [details] [diff] [review] patch Review of attachment 8960387 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the follow up. Should we file a separate bug for android or just keep this open?
Attachment #8960387 -
Flags: review?(erahm) → review+
|
|
Assignee | |
Comment 4•6 years ago
|
||
Thanks! I filed bug 1447363 to figure out what's leaking on android. If that's relatively straightforward we can add this assertion to android builds when we fix that.
|
|
Assignee | |
Comment 5•6 years ago
|
||
Here's try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cbb10ec3cbaf63f415e582e8362b0563eafd9b1
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/faa9d965f89e enforce that NSS_Shutdown succeeds on debug, non-android platforms (to prevent NSS resource leaks) r=erahm
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/faa9d965f89e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•