Closed Bug 1437165 Opened 6 years ago Closed 6 years ago

Handle unimplemented attributes in RsdparsaSdpAttributeList::LoadAttribute

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dminor, Assigned: johannes.willbold)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

There are a whole slew of unimplemented attributes in RsdparsaSdpAttributeList::LoadAttribute. We need to figure out which ones are relevant and implement them.
Assignee: nobody → johannes.willbold
Currently the attributes rtcp-rsize, connection, label and ice-mismatch are not handled and thus are not implemented in the rust parser. Is any of these relevant and needs an implementation?
Flags: needinfo?(docfaraday)
a=rtcp-rsize: Let's do that in bug 1279153
a=connection: I don't think so. abr?
a=label: abr?
a=ice-mismatch: Probably not.
Flags: needinfo?(docfaraday) → needinfo?(adam)
(In reply to Byron Campen [:bwc] from comment #2)
> a=rtcp-rsize: Let's do that in bug 1279153
Good call.

> a=connection: I don't think so. abr?
> a=label: abr?
> a=ice-mismatch: Probably not.

No, no and no would be my vote.
I *think* we need "connection" to handle session renegotiation correctly when datachannels are in use, right?

I agree that we don't need "label."

It's not clear that we need to do anything with "ice-mismatch," as the ICE spec simply says when it's generated and not what to do when you receive it.
Flags: needinfo?(adam)
Comment on attachment 8994609 [details]
Bug 1437165: Handled unimplemented attributes in RsdparsaSdpAttributeList::LoadAttribute,

https://reviewboard.mozilla.org/r/259144/#review266172
Attachment #8994609 - Flags: review?(docfaraday) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/f8aea5bf386a
Handled unimplemented attributes in RsdparsaSdpAttributeList::LoadAttribute, r=bwc
https://hg.mozilla.org/mozilla-central/rev/f8aea5bf386a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: