1437171 - Implement Permission API updates for WebMIDI

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P3)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

The Permission API (i.e. what's in dom/permissions) currently lists midi as an "unhandled permission". Once bug 1201590 lands, we'll have internal support for midi permissions that we should then expose to the web.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1437171 - Add Web MIDI support in `navigator.permissions.query()`. r?pbz!,smaug!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51b2a95943c0
Add Web MIDI support in `navigator.permissions.query()`. r=webidl,smaug,pbz

Comment 3

[Iulian Moraru]

Backed out for causing wpt failures on all-permissions.html related to query "midi" permission.

Push with failures

Failure log

Backout link

[task 2022-12-15T03:43:31.642Z] 03:43:31     INFO - TEST-START | /permissions/all-permissions.html
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - 
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-PASS | /permissions/all-permissions.html | Query "notifications" permission 
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-PASS | /permissions/all-permissions.html | Query "persistent-storage" permission 
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-PASS | /permissions/all-permissions.html | Query "push" permission 
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "accelerometer" permission - promise_test: Unhandled rejection with value: object "TypeError: 'accelerometer' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "ambient-light-sensor" permission - promise_test: Unhandled rejection with value: object "TypeError: 'ambient-light-sensor' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "background-fetch" permission - promise_test: Unhandled rejection with value: object "TypeError: 'background-fetch' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "background-sync" permission - promise_test: Unhandled rejection with value: object "TypeError: 'background-sync' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "bluetooth" permission - promise_test: Unhandled rejection with value: object "TypeError: 'bluetooth' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.565Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "gyroscope" permission - promise_test: Unhandled rejection with value: object "TypeError: 'gyroscope' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.566Z] 03:43:32     INFO - TEST-FAIL | /permissions/all-permissions.html | Query "magnetometer" permission - promise_test: Unhandled rejection with value: object "TypeError: 'magnetometer' (value of 'name' member of PermissionDescriptor) is not a valid value for enumeration PermissionName."
[task 2022-12-15T03:43:32.566Z] 03:43:32     INFO - TEST-UNEXPECTED-PASS | /permissions/all-permissions.html | Query "midi" permission - expected FAIL
[task 2022-12-15T03:43:32.566Z] 03:43:32     INFO - TEST-INFO | expected FAIL
[task 2022-12-15T03:43:32.631Z] 03:43:32     INFO - TEST-OK | /permissions/all-permissions.html | took 990ms
[task 2022-12-15T03:43:32.978Z] 03:43:32     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2022-12-15T03:43:33.076Z] 03:43:33     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2022-12-15T03:43:33.077Z] 03:43:33     INFO - Closing logging queue
[task 2022-12-15T03:43:33.077Z] 03:43:33     INFO - queue closed
[task 2022-12-15T03:43:33.089Z] 03:43:33     INFO - Setting up ssl
[task 2022-12-15T03:43:33.106Z] 03:43:33     INFO - certutil | b''
[task 2022-12-15T03:43:33.123Z] 03:43:33     INFO - certutil | b''
[task 2022-12-15T03:43:33.134Z] 03:43:33     INFO - certutil | b'\nCertificate Nickname                                         Trust Attributes\n                                                             SSL,S/MIME,JAR/XPI\n\nweb-platform-tests                                           CT,, \n'
[task 2022-12-15T03:43:33.697Z] 03:43:33     INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test_runner
[task 2022-12-15T03:43:34.896Z] 03:43:34     INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.TestRunnerActivity -a android.intent.action.MAIN --es env0 MOZ_CRASHREPORTER=1 --es env1 MOZ_CRASHREPORTER_NO_REPORT=1 --es env2 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env4 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env6 R_LOG_LEVEL=6 --es env7 R_LOG_DESTINATION=stderr --es env8 R_LOG_VERBOSE=1 --es env9 MOZ_PROCESS_LOG=/tmp/tmpctwrzryopidlog --es env10 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env11 STYLO_THREADS=1 --es arg0 -no-remote --es arg1 -profile --es arg2 /data/local/tmp/test_root/profile --es arg3 --marionette --es arg4 about:blank --ez use_multiprocess True
[task 2022-12-15T03:43:36.067Z] 03:43:36     INFO - Starting runner
[task 2022-12-15T03:43:39.098Z] 03:43:39     INFO - TEST-START | /permissions/idlharness.any.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0de1acdd7ea9
Add Web MIDI support in `navigator.permissions.query()`. r=webidl,smaug,pbz

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0de1acdd7ea9

Comment 6

[Ruth John]

Tracking issue for MDN updates https://github.com/mdn/content/issues/23680