1437188 - 14,000 fetch related warnings during testing on linux64 debug

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eric Rahm [:erahm]]

>  3802 WARNING: Retargeting failed: file dom/fetch/FetchConsumer.cpp, line 591
>  3802 WARNING: 'NS_FAILED(rv)', file dom/fetch/FetchConsumer.cpp, line 590
>  2117 WARNING: 'aRv.Failed()', file dom/fetch/Request.cpp, line 331
>  2105 WARNING: 'aRv.Failed()', file dom/fetch/Fetch.cpp, line 476
>  2035 WARNING: 'aRv.Failed()', file dom/fetch/Request.cpp, line 145

I assume these were all convenient warnings during development but probably aren't useful at this point.

3,800 instances of "Retargeting failed" emitted from dom/fetch/FetchConsumer.cpp during linux64 debug testing

> 3802 WARNING: Retargeting failed: file dom/fetch/FetchConsumer.cpp, line 591

This warning [1] shows up in the following test suites:

>   3649 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>     45 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>     45 - test-linux64/debug-mochitest-e10s-9 9
>     13 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>     12 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>     10 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      6 - test-linux64/debug-marionette-e10s Mn
>      6 - test-linux64/debug-marionette-headless-e10s MnH
>      4 - test-linux64/debug-web-platform-tests-wdspec-e10s Wd
>      2 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>      2 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>      2 - test-linux64/debug-mochitest-e10s-4 4
>      2 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>      1 - test-linux64/debug-mochitest-e10s-6 6
>      1 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>      1 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
>      1 - test-linux64/debug-web-platform-tests-e10s-1 wpt1

It shows up in 47 tests. A few of the most prevalent:

>   1822 - [e10s] /mimesniff/mime-types/parsing.any.html
>   1822 - [e10s] /mimesniff/mime-types/parsing.any.worker.html
>     30 - [e10s] dom/tests/mochitest/fetch/test_readableStreams.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_request_sw_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_response_sw_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_fetch_basic_http_sw_empty_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_request.html
>      8 - [e10s] /fetch/api/request/request-consume.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_fetch_basic_http_sw_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_response.html

[1] https://hg.mozilla.org/mozilla-central/annotate/aac7218d8624/dom/fetch/FetchConsumer.cpp#l591

3,800 instances of "'NS_FAILED(rv)'" emitted from dom/fetch/FetchConsumer.cpp during linux64 debug testing

> 3802 WARNING: 'NS_FAILED(rv)', file dom/fetch/FetchConsumer.cpp, line 590

This warning [1] shows up in the following test suites:

>   3649 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>     45 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>     45 - test-linux64/debug-mochitest-e10s-9 9
>     13 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>     12 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>     10 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>      6 - test-linux64/debug-marionette-e10s Mn
>      6 - test-linux64/debug-marionette-headless-e10s MnH
>      4 - test-linux64/debug-web-platform-tests-wdspec-e10s Wd
>      2 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>      2 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>      2 - test-linux64/debug-mochitest-e10s-4 4
>      2 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>      1 - test-linux64/debug-mochitest-e10s-6 6
>      1 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>      1 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
>      1 - test-linux64/debug-web-platform-tests-e10s-1 wpt1

It shows up in 47 tests. A few of the most prevalent:

>   1822 - [e10s] /mimesniff/mime-types/parsing.any.html
>   1822 - [e10s] /mimesniff/mime-types/parsing.any.worker.html
>     30 - [e10s] dom/tests/mochitest/fetch/test_readableStreams.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_request_sw_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_response_sw_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_fetch_basic_http_sw_empty_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_request.html
>      8 - [e10s] /fetch/api/request/request-consume.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_fetch_basic_http_sw_reroute.html
>      8 - [e10s] dom/tests/mochitest/fetch/test_response.html

[1] https://hg.mozilla.org/mozilla-central/annotate/aac7218d8624/dom/fetch/FetchConsumer.cpp#l590

2,100 instances of "'aRv.Failed()'" emitted from dom/fetch/Request.cpp during linux64 debug testing

> 2117 WARNING: 'aRv.Failed()', file dom/fetch/Request.cpp, line 331

This warning [1] shows up in the following test suites:

>    323 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     92 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>     83 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>     80 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>     73 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
>     67 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>     66 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>     66 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>     65 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>     63 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>     62 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>     60 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>     57 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>     41 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
>     40 - test-linux64/debug-mochitest-chrome-2 c2
>     37 - test-linux64/debug-mochitest-e10s-9 9
>     37 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>     37 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
>     36 - test-linux64/debug-mochitest-chrome-1 c1
>     34 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
>     34 - test-linux64/debug-mochitest-chrome-3 c3
>     32 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
>     31 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
>     30 - test-linux64/debug-mochitest-clipboard-e10s cl
>     24 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     24 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
>     22 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     20 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>     19 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     19 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>     18 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     17 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>     15 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>     14 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
>     14 - test-linux64/debug-test-verify-e10s TV
>     14 - test-linux64/debug-mochitest-e10s-15 15
>     11 - test-linux64/debug-mochitest-e10s-8 8
>     11 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
>     11 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>     10 - test-linux64/debug-mochitest-e10s-4 4
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
>     10 - test-linux64/debug-mochitest-e10s-5 5
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
>     10 - test-linux64/debug-mochitest-e10s-1 1
>     10 - test-linux64/debug-mochitest-e10s-10 10
>      9 - test-linux64/debug-mochitest-e10s-12 12
>      9 - test-linux64/debug-mochitest-e10s-11 11
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
>      9 - test-linux64/debug-mochitest-e10s-7 7
>      9 - test-linux64/debug-mochitest-e10s-3 3
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
>      8 - test-linux64/debug-mochitest-e10s-6 6
>      8 - test-linux64/debug-mochitest-e10s-16 16
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
>      8 - test-linux64/debug-mochitest-e10s-14 14
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
>      8 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
>      8 - test-linux64/debug-mochitest-e10s-13 13
>      8 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>      8 - test-linux64/debug-mochitest-gpu-e10s gpu
>      7 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>      7 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>      6 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>      6 - test-linux64/debug-mochitest-media-e10s-3 mda3
>      5 - test-linux64/debug-mochitest-e10s-2 2
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>      5 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>      4 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>      3 - test-linux64/debug-mochitest-media-e10s-2 mda2
>      3 - test-linux64/debug-mochitest-media-e10s-1 mda1
>      2 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>      2 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>      2 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>      1 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>      1 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>      1 - test-linux64/debug-mochitest-a11y a11y
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12

It shows up in 1140 tests. A few of the most prevalent:

>    476 - [e10s] Shutdown
>     93 -        Shutdown
>     62 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_4.js
>     47 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_uitour.js
>     46 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_3.js
>     43 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification.js
>     25 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_tours.js
>     24 - [e10s] dom/tests/mochitest/fetch/test_request_sw_reroute.html
>     24 - [e10s] dom/tests/mochitest/fetch/test_request.html
>     14 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_2.js

[1] https://hg.mozilla.org/mozilla-central/annotate/aac7218d8624/dom/fetch/Request.cpp#l331

2,100 instances of "'aRv.Failed()'" emitted from dom/fetch/Fetch.cpp during linux64 debug testing

> 2105 WARNING: 'aRv.Failed()', file dom/fetch/Fetch.cpp, line 476

This warning [1] shows up in the following test suites:

>    323 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>    112 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>     83 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>     80 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>     73 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
>     68 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>     67 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>     66 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>     66 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>     65 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>     63 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>     60 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>     57 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>     41 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
>     40 - test-linux64/debug-mochitest-chrome-2 c2
>     37 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
>     36 - test-linux64/debug-mochitest-chrome-1 c1
>     34 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
>     34 - test-linux64/debug-mochitest-chrome-3 c3
>     32 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
>     31 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
>     30 - test-linux64/debug-mochitest-clipboard-e10s cl
>     24 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     24 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
>     22 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     20 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>     19 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     19 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>     18 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     18 - test-linux64/debug-mochitest-e10s-9 9
>     18 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>     17 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>     15 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>     14 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
>     14 - test-linux64/debug-test-verify-e10s TV
>     14 - test-linux64/debug-mochitest-e10s-15 15
>     11 - test-linux64/debug-mochitest-e10s-8 8
>     11 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
>     11 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>     10 - test-linux64/debug-mochitest-e10s-4 4
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
>     10 - test-linux64/debug-mochitest-e10s-5 5
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
>     10 - test-linux64/debug-mochitest-e10s-1 1
>     10 - test-linux64/debug-mochitest-e10s-10 10
>      9 - test-linux64/debug-mochitest-e10s-12 12
>      9 - test-linux64/debug-mochitest-e10s-11 11
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
>      9 - test-linux64/debug-mochitest-e10s-7 7
>      9 - test-linux64/debug-mochitest-e10s-3 3
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
>      8 - test-linux64/debug-mochitest-e10s-6 6
>      8 - test-linux64/debug-mochitest-e10s-16 16
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
>      8 - test-linux64/debug-mochitest-e10s-14 14
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
>      8 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
>      8 - test-linux64/debug-mochitest-e10s-13 13
>      8 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>      8 - test-linux64/debug-mochitest-gpu-e10s gpu
>      7 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>      7 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>      6 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>      6 - test-linux64/debug-mochitest-media-e10s-3 mda3
>      5 - test-linux64/debug-mochitest-e10s-2 2
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>      5 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>      4 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>      3 - test-linux64/debug-mochitest-media-e10s-2 mda2
>      3 - test-linux64/debug-mochitest-media-e10s-1 mda1
>      2 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>      2 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>      2 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>      1 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>      1 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>      1 - test-linux64/debug-mochitest-a11y a11y
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12

It shows up in 1140 tests. A few of the most prevalent:

>    476 - [e10s] Shutdown
>     93 -        Shutdown
>     62 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_4.js
>     47 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_uitour.js
>     46 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_3.js
>     43 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification.js
>     25 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_tours.js
>     14 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_2.js
>     14 -        browser/components/shell/test/test_headless_screenshot.html
>     13 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_click_auto_complete_tour.js

[1] https://hg.mozilla.org/mozilla-central/annotate/aac7218d8624/dom/fetch/Fetch.cpp#l476

2,000 instances of "'aRv.Failed()'" emitted from dom/fetch/Request.cpp during linux64 debug testing

> 2035 WARNING: 'aRv.Failed()', file dom/fetch/Request.cpp, line 145

This warning [1] shows up in the following test suites:

>    323 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>     83 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>     78 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>     76 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>     73 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
>     66 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>     65 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>     63 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>     63 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>     62 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>     60 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>     60 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>     57 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>     41 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
>     40 - test-linux64/debug-mochitest-chrome-2 c2
>     37 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
>     36 - test-linux64/debug-mochitest-chrome-1 c1
>     34 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
>     34 - test-linux64/debug-mochitest-chrome-3 c3
>     32 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
>     31 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
>     30 - test-linux64/debug-mochitest-clipboard-e10s cl
>     24 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>     24 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
>     22 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>     20 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>     19 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>     19 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>     18 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>     17 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>     15 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>     14 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
>     14 - test-linux64/debug-test-verify-e10s TV
>     14 - test-linux64/debug-mochitest-e10s-15 15
>     11 - test-linux64/debug-mochitest-e10s-8 8
>     11 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
>     11 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>     10 - test-linux64/debug-mochitest-e10s-9 9
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
>     10 - test-linux64/debug-mochitest-e10s-4 4
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
>     10 - test-linux64/debug-mochitest-e10s-5 5
>     10 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
>     10 - test-linux64/debug-mochitest-e10s-1 1
>     10 - test-linux64/debug-mochitest-e10s-10 10
>      9 - test-linux64/debug-mochitest-e10s-12 12
>      9 - test-linux64/debug-mochitest-e10s-11 11
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
>      9 - test-linux64/debug-mochitest-e10s-7 7
>      9 - test-linux64/debug-mochitest-e10s-3 3
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
>      9 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
>      8 - test-linux64/debug-mochitest-e10s-6 6
>      8 - test-linux64/debug-mochitest-e10s-16 16
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
>      8 - test-linux64/debug-mochitest-e10s-14 14
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
>      8 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>      8 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
>      8 - test-linux64/debug-mochitest-e10s-13 13
>      8 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>      8 - test-linux64/debug-mochitest-gpu-e10s gpu
>      7 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>      7 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>      6 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>      6 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>      6 - test-linux64/debug-mochitest-media-e10s-3 mda3
>      5 - test-linux64/debug-mochitest-e10s-2 2
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>      5 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>      5 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>      4 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>      3 - test-linux64/debug-mochitest-media-e10s-2 mda2
>      3 - test-linux64/debug-mochitest-media-e10s-1 mda1
>      2 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>      2 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>      2 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>      1 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>      1 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>      1 - test-linux64/debug-mochitest-a11y a11y
>      1 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12

It shows up in 1124 tests. A few of the most prevalent:

>    476 - [e10s] Shutdown
>     93 -        Shutdown
>     62 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_4.js
>     47 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_uitour.js
>     46 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_3.js
>     43 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification.js
>     25 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_tours.js
>     14 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_2.js
>     14 -        browser/components/shell/test/test_headless_screenshot.html
>     13 - [e10s] browser/extensions/onboarding/test/browser/browser_onboarding_notification_click_auto_complete_tour.js

[1] https://hg.mozilla.org/mozilla-central/annotate/aac7218d8624/dom/fetch/Request.cpp#l145

Comment 1

[Eric Rahm [:erahm]]

There's also:

>   657 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file dom/fetch/FetchDriver.cpp, line 721
>   133 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x805303F4: file dom/fetch/FetchDriver.cpp, line 721
>   106 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file dom/fetch/FetchDriver.cpp, line 721

Comment 2

[Eric Rahm [:erahm]]

Attachment: Remove verbose fetch related warnings

This removes the most verbose fetch related warnings. Cumulatively these
account for about 15,000 warnings during testing.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8949909 [details] [diff] [review]
Remove verbose fetch related warnings

Review of attachment 8949909 [details] [diff] [review]:
-----------------------------------------------------------------

Two of the three changes look fine.  I would like to keep the re-targeting warning, though.  I've provided an alternative solution to silence the particular warnings we are getting currently.

::: dom/fetch/FetchConsumer.cpp
@@ +586,5 @@
>    nsCOMPtr<nsIThreadRetargetableRequest> rr = do_QueryInterface(pump);
>    if (rr) {
>      nsCOMPtr<nsIEventTarget> sts = do_GetService(NS_STREAMTRANSPORTSERVICE_CONTRACTID);
> +    // It's common for this to fail, so we just ignore it.
> +    Unused << rr->RetargetDeliveryTo(sts);

Please don't remove this one.  We don't want to hard fail here, but its also a problem if we start failing to re-target often.  Currently our only way to notice when this happens is by getting this warning.  (Which I do look for when I work on this stuff.)

In this case we always fail to retarget when `mConsumerType == CONSUME_BLOB` because we are explicitly adding the MutableBlobStreamListener here:

https://searchfox.org/mozilla-central/rev/b9f1a4ecba48b2d8c686669e32d109c40e927b48/dom/fetch/FetchConsumer.cpp#560

The MutableBlobStreamListener is not retargetable.

Can you do something like this instead of removing the warning:

--- a/dom/fetch/FetchConsumer.cpp
+++ b/dom/fetch/FetchConsumer.cpp
@@ -579,17 +579,18 @@ FetchBodyConsumer<Derived>::BeginConsume
   // stays alive for the lifetime of the FetchConsumer.
   mConsumeBodyPump = pump;

   // It is ok for retargeting to fail and reads to happen on the main thread.
   autoReject.DontFail();

   // Try to retarget, otherwise fall back to main thread.
   nsCOMPtr<nsIThreadRetargetableRequest> rr = do_QueryInterface(pump);
-  if (rr) {
+  nsCOMPtr<nsIThreadRetargetableStreamListener> rl = do_QueryInterface(listener);
+  if (rr && rl) {
     nsCOMPtr<nsIEventTarget> sts = do_GetService(NS_STREAMTRANSPORTSERVICE_CONTRACTID);
     rv = rr->RetargetDeliveryTo(sts);
     if (NS_WARN_IF(NS_FAILED(rv))) {
       NS_WARNING("Retargeting failed");
     }
   }
 }

::: dom/fetch/FetchDriver.cpp
@@ +719,5 @@
>      rv = chan->AsyncOpen2(this);
>    }
> +  if (NS_FAILED(rv)) {
> +    return rv;
> +  }

This change is fine.

::: dom/fetch/Request.cpp
@@ +142,4 @@
>    MOZ_ASSERT(NS_IsMainThread());
>    nsCOMPtr<nsIURI> uri;
>    aRv = NS_NewURI(getter_AddRefs(uri), aInput, nullptr, nullptr);
> +  if (aRv.Failed()) {

The changes in this file are fine.

Comment 4

[Eric Rahm [:erahm]]

(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8949909 [details] [diff] [review]
> Remove verbose fetch related warnings
> 
> Review of attachment 8949909 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Two of the three changes look fine.  I would like to keep the re-targeting
> warning, though.  I've provided an alternative solution to silence the
> particular warnings we are getting currently.

Thanks that sounds reasonable. I was a little unsure about removing the retargeting warning as well.

> ::: dom/fetch/FetchConsumer.cpp
> @@ +586,5 @@
> >    nsCOMPtr<nsIThreadRetargetableRequest> rr = do_QueryInterface(pump);
> >    if (rr) {
> >      nsCOMPtr<nsIEventTarget> sts = do_GetService(NS_STREAMTRANSPORTSERVICE_CONTRACTID);
> > +    // It's common for this to fail, so we just ignore it.
> > +    Unused << rr->RetargetDeliveryTo(sts);
> 
> Please don't remove this one.  We don't want to hard fail here, but its also
> a problem if we start failing to re-target often.  Currently our only way to
> notice when this happens is by getting this warning.  (Which I do look for
> when I work on this stuff.)
> 
> In this case we always fail to retarget when `mConsumerType == CONSUME_BLOB`
> because we are explicitly adding the MutableBlobStreamListener here:

Thanks for taking the time to track down the root cause. I'm happy to update as you've suggested.

> https://searchfox.org/mozilla-central/rev/
> b9f1a4ecba48b2d8c686669e32d109c40e927b48/dom/fetch/FetchConsumer.cpp#560
> 
> The MutableBlobStreamListener is not retargetable.
> 
> Can you do something like this instead of removing the warning:
> 
> --- a/dom/fetch/FetchConsumer.cpp
> +++ b/dom/fetch/FetchConsumer.cpp
> @@ -579,17 +579,18 @@ FetchBodyConsumer<Derived>::BeginConsume
>    // stays alive for the lifetime of the FetchConsumer.
>    mConsumeBodyPump = pump;
> 
>    // It is ok for retargeting to fail and reads to happen on the main
> thread.
>    autoReject.DontFail();
> 
>    // Try to retarget, otherwise fall back to main thread.
>    nsCOMPtr<nsIThreadRetargetableRequest> rr = do_QueryInterface(pump);
> -  if (rr) {
> +  nsCOMPtr<nsIThreadRetargetableStreamListener> rl =
> do_QueryInterface(listener);
> +  if (rr && rl) {
>      nsCOMPtr<nsIEventTarget> sts =
> do_GetService(NS_STREAMTRANSPORTSERVICE_CONTRACTID);
>      rv = rr->RetargetDeliveryTo(sts);
>      if (NS_WARN_IF(NS_FAILED(rv))) {

I'm still going to remove the extra warning ;)

>        NS_WARNING("Retargeting failed");
>      }
>    }
>  }

Comment 5

[Eric Rahm [:erahm]]

Attachment: Part 1: Remove verbose fetch related warnings

Ben, this is just the simple removals split out.

Comment 6

[Eric Rahm [:erahm]]

Attachment: Part 2: Only try to retarget if the listener is retargetable

MutableBlobStreamListener isn't retargetable, in order to avoid warning about
it we don't try retarget it at all. This should remove about 4,000 warnings
during testing.

Comment 7

[Eric Rahm [:erahm]]

Try run to test if the warnings are cleared and nothing breaks:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=50f479311447a8be374f42d4898cc58748bbf9ae

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a9343b61df9
Part 1: Remove verbose fetch related warnings. r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d5573fa9395
Part 2: Only try to retarget if the listener is retargetable. r=bkelly

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1a9343b61df9
https://hg.mozilla.org/mozilla-central/rev/5d5573fa9395