1437270 - Port |bug 1152332 - Let connection proxy filters return the result asynchronously| to Mailnews - TEST-UNEXPECTED-TIMEOUT | comm/mailnews/compose/test/unit/test_smtpProxy.js

Status: RESOLVED FIXED

(MailNews Core :: Networking, defect)

Description

[Jorg K (CEST = GMT+2)]

This makes our four proxy tests fail:
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/compose/test/unit/test_smtpProxy.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/imap/test/unit/test_imapProxy.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/local/test/unit/test_pop3Proxy.js | Test timed out
TEST-UNEXPECTED-TIMEOUT | comm/mailnews/news/test/unit/test_nntpProxy.js | Test timed out

Comment 1

[Jorg K (CEST = GMT+2)]

Honza, I'm looking at the tests, for example:
https://dxr.mozilla.org/comm-central/source/mailnews/compose/test/unit/test_smtpProxy.js
and it's rather short.

I'm a little familiar with proxy resolution in mailnews, since I worked on bug 791645. As far as I know, we don't use proxy filters, so it's unclear to my why bug 1152332 affects our tests.

Any hint would be welcome.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1437270-disable-proxy-tests.patch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9b23f29d39df
temporarily disable proxy tests. rs=bustage-fix

Comment 4

[Honza Bambas (:mayhemer)]

Jorg, I knew I wanted to do one more thing before landing that patch - file a bug for mailnews!  Sorry about that.

I can help fixing this.  Apparently, the code at [1] needs an update, very simple, similarly to [2]:

[1] https://dxr.mozilla.org/comm-central/rev/fdbbb8fee22945c32eeaaa83526b9ad4f360e99a/mailnews/test/resources/NetworkTestUtils.jsm#248
[2] https://hg.mozilla.org/mozilla-central/rev/ce34d962b0df#l5.1

Comment 5

[Jorg K (CEST = GMT+2)]

Oh, I've just written a patch, and I'm checking whether the tests pass now.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1437270-proxy.patch - not working

Hmm, I ported the two lines from
https://hg.mozilla.org/mozilla-central/rev/ce34d962b0df#l5.12
and the SMTP test, the only one I tried, still hangs. So I must be missing something.

Maybe I should leave it to the assignee ;-) (sorry, I didn't see the Assignee: [e-mail] → [e-mail])

Comment 7

[Honza Bambas (:mayhemer)]

There are two |return| statements in that function ;)  you need to update both.

Comment 8

[Honza Bambas (:mayhemer)]

Attachment: v1

Comment 9

[Honza Bambas (:mayhemer)]

Comment on attachment 8950211 [details] [diff] [review]
v1

Jorg, from some reason I'm getting "ERROR: Cannot find project mail" when building tbird, so I can't test locally.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8950211 [details] [diff] [review]
v1

All four tests pass with this. Thanks!
I'll get this landed, I hope you're satisfied with my r+. Seems like a straight port of https://hg.mozilla.org/mozilla-central/rev/ce34d962b0df#l5.12 ... if one doesn't overlook half the work like I did ;-(

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/782575b2232e
Backed out changeset 9b23f29d39df: re-enable temporarily disabled test. a=jorgk
https://hg.mozilla.org/comm-central/rev/41a8e252b0c2
Port bug 1152332 to mailnews: proxy filters return the result asynchronously. r=jorgk

Comment 12

[Honza Bambas (:mayhemer)]

Thanks for quickly testing and landing this!  Could not build my tb locally...