1437280 - [wpt-sync] PR 9472 - [Gecko Bug 1424878] Not having cached style data doesn't guarantee we don't need to update media query stuff.

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

In particular,  even when there are no frames, we may have used the rule
cascades / stylist data (for different stuff, like font-feature-values, thus the
regressing bug).

Using the old rule cascades / stylist data without knowing it has changed is
wrong, thus the bug.

Now that media query change stuff is async and has a well-defined processing
point, we should be able to just call it without too much worry.

Also note that at the point the extra hints are passed, if there's no root frame
/ elements are not styled / etc, we'll optimize away the change hint.

The test-case intermittently fails without this patch, but I didn't manage to
make a better one, unfortunately :(
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1424878
gecko-commit: d6e7f810f7d301cb928b6ed16837a3b4f660a069
gecko-integration-branch: autoland
gecko-reviewers: bz

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c2fca024ea3c1f4bd7f2c8851b77e4963f35e21

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4338763871cd3d8cb9819a2ea939804b0d4c244d

Comment 3

[Jet Villegas (inactive)]

[ Triage 2017/02/20: P3 ]