Open Bug 1437287 Opened 6 years ago Updated 2 years ago

Add an "Add bookmark here" option

Categories

(Firefox :: Bookmarks & History, enhancement, P5)

58 Branch
enhancement

Tracking

()

UNCONFIRMED

People

(Reporter: morpheustdk, Unassigned)

References

(Depends on 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20180206200532

Steps to reproduce:

Open the bookmarks in the sidebar or from the drop down and navigate deep into a bookmark hierarchy. Now you want to bookmark the current page into this location you have to navigate via the browse option to the same location which is quite time consuming. 


Actual results:

Have to re-navigate toi the same location in the bookmark dialog


Expected results:

As per the former Add Bookmark Here 2 addon which cannot be implemented as a web extension ( https://addons.mozilla.org/en-GB/firefox/addon/add-bookmark-here-2/) on the context menu for the folder you wish the bookmark to be added to have an option Add Bookmark Here which will bookmark the current page into that folder.
You can click and drag the circled (i) icon on the left side of the location bar into various UI elements. This includes any folders in the bookmarks sidebar (hold and hover a few moments for the folders to expand), the bookmarks toolbar, and the desktop.

As for a context menu item in the bookmarks menu and bookmarks button menu, there's an add-on for that:
https://addons.mozilla.org/firefox/addon/bookmark-tab-here/

I'll leave this open in the off-chance the request is going to be reconsidered, but it'll probably be marked as a duplicate of bug 217490.
Severity: normal → enhancement
Has Regression Range: --- → irrelevant
Has STR: --- → yes
Component: Untriaged → Bookmarks & History
OS: Unspecified → All
Hardware: Unspecified → All
Is there anything missing from the add-on suggested in comment 1, that makes this a relevant request for the Core functionality?
We could figure out the misses with the WebExt team.
Flags: needinfo?(morpheustdk)
At present the web extension cannot work with the bookmarks opened from the sidebar as the API doesn't support that according to the thread about the extension on Mozillazine: http://forums.mozillazine.org/viewtopic.php?f=48&t=3038053&p=14792406#p14792406. The new API only exists as it is in v59 which is not currently a stable release.

This is such a basic and convenient UI feature that even if that can be addressed by adding to the WebExtensions API (and it probably should be anyway) I would suggest that it might be a good candidate for core functionality but if it is to only be available via an extension then it should behave consistently across all UI elements that deal with bookmarks.

Thanks
(In reply to morpheustdk from comment #3)
> At present the web extension cannot work with the bookmarks opened from the
> sidebar

That's a confirmed P5 bug, the add-ons team will likely accept a patch for it, if someone makes one.

> The new API only exists as it is in
> v59 which is not currently a stable release.

Even if we'd fix this bug, it wouldn't appear before Firefox 60 or 61.

> if it is to only be available via an extension then it
> should behave consistently across all UI elements that deal with bookmarks.

I agree, but there's already Bug 1419195 opened for that.

The bookmarking experience is not great, but I'm not sure this is the way to go. We already started a discussion with UX to understand which direction to go.
I'm leaving this open as an unconfirmed P5 for now, that means for now we won't accept patches, because we should first understand which direction UX wants to move.

For now I'd suggest to cooperate on fixing Bug 1419195 so that it's implementable through a WebExt.
Flags: needinfo?(morpheustdk)
Priority: -- → P5
Summary: FEATURE REQUEST: Implement Add bookmark here option in Firefox quantum → Add an "Add bookmark here" option
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.