Restore the "menuitem-iconic-desc-noaccel" binding after the removal in bug 1418459

RESOLVED FIXED in Thunderbird 60.0

Status

enhancement
RESOLVED FIXED
Last year
11 months ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

(Blocks 1 bug)

unspecified
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Bug 1418459 removed the "menuitem-iconic-desc-noaccel" binding. We need it for the description in composer's from menupoup.
The descriptions are back with this patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8950014 - Flags: review?(jorgk)
Comment on attachment 8950014 [details] [diff] [review]
menuitem-iconic-desc-noaccel.patch

Yes, this works, thank you.
Attachment #8950014 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dbaae0514e5e
Restore the "menuitem-iconic-desc-noaccel" binding after the removal in bug 1418459. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 60.0
This does not seem to work for me on Linux. May some rule be overriding this style?
Posted patch Bug1437315-fup.patch.patch (obsolete) — Splinter Review
The code you removed previously needs to be re-added with binding path updated.
Attachment #8950023 - Flags: review?(acelists)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Posted patch Bug1437315-fup.patch (obsolete) — Splinter Review
Make the selector more specific in bindings.css.
Attachment #8950023 - Attachment is obsolete: true
Attachment #8950023 - Flags: review?(acelists)
Attachment #8950024 - Flags: review?(acelists)
Comment on attachment 8950024 [details] [diff] [review]
Bug1437315-fup.patch

Review of attachment 8950024 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, works on Linux.

::: mail/base/content/bindings.css
@@ +27,5 @@
>  menulist[type="description"] {
>    -moz-binding: url("chrome://messenger/content/mailWidgets.xml#menulist-description");
>  }
>  
> +menupopup > menuitem[description] {

Semantically it would probably be more correct to do "menulist[type="description"] menuitem[description]" or "menulist[type="description"] > menupopup > menuitem[description]", would that be much slower to be relevant?
Attachment #8950024 - Flags: review?(acelists) → review+
Made the selector more specific.
Attachment #8950024 - Attachment is obsolete: true
Attachment #8950051 - Flags: review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/388dfe87bd6e
Follow-up: Make the menuitem[description] in bindings.css more specific. r=aceman
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.