1437385 - Themed arrow panels need to have some colors set for the zoom-button and the addon-update bar

Status: RESOLVED DUPLICATE of bug 1417880

(Firefox :: Theme, enhancement)

Comment 1

[Connor Masini]

Attachment: Bug 1437385: Themed arrow panels need to have some colors set for the zoom-button and the addon-update bar.

Review commit: https://reviewboard.mozilla.org/r/219350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219350/

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8950081 [details]
Bug 1437385: Themed arrow panels need to have some colors set for the zoom-button and the addon-update bar.

https://reviewboard.mozilla.org/r/219350/#review225062

::: browser/themes/shared/customizableui/panelUI.inc.css:992
(Diff revision 1)
>  .PanelUI-subView .toolbaritem-combined-buttons > .subviewbutton:not(.subviewbutton-iconic) {
>    background-color: #f9f9f9;
>    border: 1px solid #e1e1e1;
>    border-radius: 10000px;
>    padding: 1px 8px;
>  }

As I said in the other bug, this can be combined with the #appMenu-zoomReset-button rule, since both rules target the same thing.


Also, the border-color needs to change to var(--panel-separator-color)

Comment 3

[Connor Masini]

I was going to make that change in the other bug.  Should I do it here instead?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1417880 got backed out for eslint failures so we can move these changes there now before it gets relanded.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8950081 [details]
Bug 1437385: Themed arrow panels need to have some colors set for the zoom-button and the addon-update bar.

https://reviewboard.mozilla.org/r/219350/#review225066