1437388 - Remove differing session store write interval while in background

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Session Restore, enhancement, P3)

Description

[Jan Henning [:JanH]]

While actually reproducible, in hindsight my original theory for bug 1256277 seems rather unlikely, as it requires more or less split-second timing (see bug 1256277 comment 6) in order for tabs closed before backgrounding the app not to be written to disk.

Bug 1282830 (closing a zombie tab didn't trigger any session store update) is a much more likely candidate for those symptoms instead.

Bearing that in mind, reducing the minimum interval between successive session store writes while in background doesn't actually seem necessary any more.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1437388 - Don't set different session store write interval while in background.

We had some issues with tabs closed shortly before backgrounding Firefox re-
appearing during session restore, however in hindsight bug 1282830 (closing a
zombie tab didn't trigger a session store file write) seems a more likely cause
for that than my initial theory from bug 1256277 comment 6 (tab events
dispatched *just* before backgrounding might be processed only after our
application-background handling), because as far as I can tell the latter theory
actually requires really split-second timing.

With that in mind, the differing, smaller minimum file write interval while in
background can be removed again.

Review commit: https://reviewboard.mozilla.org/r/219366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219366/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8950093 [details]
Bug 1437388 - Don't set different session store write interval while in background.

https://reviewboard.mozilla.org/r/219366/#review225228

Comment 3

[Jan Henning [:JanH]]

Comment on attachment 8950093 [details]
Bug 1437388 - Don't set different session store write interval while in background.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/219366/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55f89e248047
Don't set different session store write interval while in background. r=esawin

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/55f89e248047