Closed
Bug 1437433
Opened 6 years ago
Closed 6 years ago
Add automated test for "Websites can be bookmarked from a private window"
Categories
(Firefox :: Bookmarks & History, enhancement, P2)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: pauly, Assigned: pauly)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file, 1 obsolete file)
2.78 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
TestRail link: https://testrail.stage.mozaws.net/index.php?/cases/view/4176 Steps: 1. Launch Firefox. 2. Open a private window from menu [≡] → New Private Window. 3. Open a website that's currently not in your bookmarks list. 4. Click the star-shaped button to bookmark it. Expected results: 1. Firefox is successfully launched. 2. A new private window is successfully opened. 3. The website in question is successfully loaded. 4. On click, the star-shaped button shows an animation and changes its color to blue. The website is successfully bookmarked and no errors are thrown for this action.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → paul.silaghi
Attachment #8950141 -
Flags: review?(standard8)
Comment 2•6 years ago
|
||
Comment on attachment 8950141 [details] [diff] [review] browser_bookmark_private_window Review of attachment 8950141 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, just a couple of comments/queries to address. ::: browser/components/places/tests/browser/browser_bookmark_private_window.js @@ +16,5 @@ > + > +add_task(async function test_add_bookmark_from_private_window() { > + let win = await BrowserTestUtils.openNewBrowserWindow({private: true}); > + let tab = win.gBrowser.selectedTab = win.gBrowser.addTab(TEST_URL); > + await BrowserTestUtils.browserLoaded(tab.linkedBrowser); We can simplify these two lines to: let tab = await BrowserTestUtils.openNewForegroundTab(gBrowser, TEST_URL); `openNewForegroundTab` automatically waits for the load to complete. @@ +34,5 @@ > + Assert.equal(bookmarkStar.getAttribute("starred"), "true", "Bookmark star changed its state correctly."); > + > + // Check if the "Page Bookmarked" panel is open. > + let bookmarkPanelTitle = win.document.getElementById("editBookmarkPanelTitle"); > + Assert.equal(bookmarkPanelTitle.value, "Page Bookmarked", "Bookmark panel title is correct."); I think this is already checked by the fact that we've done the `await shownPromise`, isn't it?
Attachment #8950141 -
Flags: review?(standard8)
Assignee | ||
Comment 3•6 years ago
|
||
Thanks for the review. Added the requested changes.
Attachment #8950141 -
Attachment is obsolete: true
Attachment #8951573 -
Flags: review?(standard8)
Comment 4•6 years ago
|
||
Comment on attachment 8951573 [details] [diff] [review] browser_bookmark_private_window Great, thanks.
Attachment #8951573 -
Flags: review?(standard8) → review+
Updated•6 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Whiteboard: [fxsearch]
Assignee | ||
Comment 5•6 years ago
|
||
Try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eabc730823fc16e8bea73993bd1d6b62ee4c49c0
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/91b807639ce3 Add a test for checking that a website can be bookmarked from a private window. r=standard8
Keywords: checkin-needed
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/91b807639ce3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•