Closed Bug 1437489 Opened 2 years ago Closed 2 years ago

Refactor jsatoms.h to split out details of the atoms table implementation

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

jsatoms.h contains both API functions for working with atoms and the implementation details of the atoms table.  Here's a patch to split out the latter into vm/AtomsTable.h.  I also removed includes of jsatom.h and jsatominlines.h where possible.
Attachment #8950181 - Flags: review?(jdemooij)
Comment on attachment 8950181 [details] [diff] [review]
split-atoms-header

Review of attachment 8950181 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! That's a lot of removed #includes.

::: js/src/vm/AtomsTable.h
@@ +73,5 @@
> +class FrozenAtomSet
> +{
> +    AtomSet* mSet;
> +
> +public:

Nit: indent with 2 spaces
Attachment #8950181 - Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aae0a2c15e00
Split out implementation of atoms table out into vm/AtomsTable.h r=jandem
https://hg.mozilla.org/mozilla-central/rev/aae0a2c15e00
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.