Closed
Bug 1437514
Opened 6 years ago
Closed 6 years ago
Check getIdForItemAt usage in test_nsINavBookmarkObserver.js
Categories
(Toolkit :: Places, enhancement, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
It looks broken but the test doesn't fail, it should be checked and removed
| Comment hidden (obsolete) |
|
Assignee | |
Comment 2•6 years ago
|
||
nvm, the real problem is the === check. the test prints warnings but doesn't fail because of the ===.
| Comment hidden (mozreview-request) |
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8954687 [details] Bug 1437514 - Remove remaining getIdForItemAt calls in test_nsINavBookmarkObserver.js. https://reviewboard.mozilla.org/r/223794/#review229828 I'm almost tempted to say we should change the parentGuid checks to check for the actual guid, but given the in-progress observer rework, then I think we can just go with this for now.
Attachment #8954687 -
Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/4b48465720bb Remove remaining getIdForItemAt calls in test_nsINavBookmarkObserver.js. r=standard8
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4b48465720bb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•