Closed Bug 1437514 Opened 4 years ago Closed 4 years ago
Id For Item At usage in test _ns INav Bookmark Observer .js
59 bytes, text/x-review-board-request
It looks broken but the test doesn't fail, it should be checked and removed
nvm, the real problem is the === check. the test prints warnings but doesn't fail because of the ===.
Comment on attachment 8954687 [details] Bug 1437514 - Remove remaining getIdForItemAt calls in test_nsINavBookmarkObserver.js. https://reviewboard.mozilla.org/r/223794/#review229828 I'm almost tempted to say we should change the parentGuid checks to check for the actual guid, but given the in-progress observer rework, then I think we can just go with this for now.
Attachment #8954687 - Flags: review?(standard8) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4b48465720bb Remove remaining getIdForItemAt calls in test_nsINavBookmarkObserver.js. r=standard8
You need to log in before you can comment on or make changes to this bug.