Closed
Bug 1437516
Opened 6 years ago
Closed 6 years ago
Remove runInBatchMode
Categories
(Toolkit :: Places, enhancement, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mak, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(2 files)
We may have to keep the notifications for now, mostly because maintenance uses them to refresh the ui. We can probably empty most of the handlers though.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•6 years ago
|
||
Note: this patch depends on the left-pane patches in bug 1310295.
Assignee | ||
Comment 4•6 years ago
|
||
Also, I left UpdateBatchScoper in place as it really needs bug 1089691 landing before it is unused.
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Mark Banner (:standard8) (afk until 19 Mar) from comment #4) > Also, I left UpdateBatchScoper in place as it really needs bug 1089691 > landing before it is unused. Yeah that bug is in a limbo, I wonder if we should take over the remaining piece (fix removeByFilter to use a .host filter instead of *.host filter) and unbitrot the patch. I start being uncomfortable with the status of async history, when we are so close to the goal.
Reporter | ||
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8958631 [details] Bug 1437516 - Remove nsINavHistoryService/nsINavBookmarksService::runInBatchMode. https://reviewboard.mozilla.org/r/227536/#review234158 ::: toolkit/components/places/nsNavBookmarks.cpp (Diff revision 1) > - nsISupports* aUserData) { > - AUTO_PROFILER_LABEL("nsNavBookmarks::RunInBatchMode", OTHER); > - > - NS_ENSURE_ARG(aCallback); > - > - mBatching = true; mBatching should be removed
Attachment #8958631 -
Flags: review?(mak77) → review+
Reporter | ||
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8958632 [details] Bug 1437516 - Rename browser_library_batch_delete.js now that it isn't testing batches. https://reviewboard.mozilla.org/r/227538/#review234172
Attachment #8958632 -
Flags: review?(mak77) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•6 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1622568f12b0 Remove nsINavHistoryService/nsINavBookmarksService::runInBatchMode. r=mak https://hg.mozilla.org/integration/autoland/rev/d11b63f72c88 Rename browser_library_batch_delete.js now that it isn't testing batches. r=mak
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1622568f12b0 https://hg.mozilla.org/mozilla-central/rev/d11b63f72c88
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•