Closed Bug 1437530 Opened 2 years ago Closed 2 years ago

Cache templates per site, rather than by contents

Categories

(Core :: JavaScript Engine, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: anba, Assigned: anba)

References

()

Details

Attachments

(1 file, 2 obsolete files)

Attached patch bug1437530.patch (obsolete) — Splinter Review
For the most part this just reverts the changes from bug 1108941, except I replaced the |RootedObject&| arguments with |HandleObject|, because the latter matches how we normally pass objects around, and I kept the call to |nonProxyIsExtensible()| instead of using |IsExtensible| for a possible small performance win.
Attachment #8950220 - Flags: review?(arai.unmht)
Comment on attachment 8950220 [details] [diff] [review]
bug1437530.patch

Review of attachment 8950220 [details] [diff] [review]:
-----------------------------------------------------------------

Great! thanks :)
Attachment #8950220 - Flags: review?(arai.unmht) → review+
Attached patch bug1437530.patch (obsolete) — Splinter Review
Update to apply cleanly on inbound after the js-internal file moves. Carrying r+.
Attachment #8950220 - Attachment is obsolete: true
Attachment #8951024 - Flags: review+
This got bitrotted at least by bug 1437978, please provide an updated patch.
Flags: needinfo?(andrebargull)
Keywords: checkin-needed
Attached patch bug1437530.patchSplinter Review
Rebased to apply on inbound. Carrying r+.
Attachment #8951024 - Attachment is obsolete: true
Flags: needinfo?(andrebargull)
Attachment #8952150 - Flags: review+
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9929099d4c41
Cache template literal objects per call site again. r=arai
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9929099d4c41
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.