Closed
Bug 1437530
Opened 6 years ago
Closed 6 years ago
Cache templates per site, rather than by contents
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
()
Details
Attachments
(1 file, 2 obsolete files)
|
23.45 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
https://github.com/tc39/ecma262/pull/890 https://github.com/tc39/test262/pull/972 This means basically just reverting the changes from bug 1108941.
|
Assignee | |
Comment 1•6 years ago
|
||
For the most part this just reverts the changes from bug 1108941, except I replaced the |RootedObject&| arguments with |HandleObject|, because the latter matches how we normally pass objects around, and I kept the call to |nonProxyIsExtensible()| instead of using |IsExtensible| for a possible small performance win.
Attachment #8950220 -
Flags: review?(arai.unmht)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8950220 [details] [diff] [review] bug1437530.patch Review of attachment 8950220 [details] [diff] [review]: ----------------------------------------------------------------- Great! thanks :)
Attachment #8950220 -
Flags: review?(arai.unmht) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=418fd4ed8fcaf4399e5dd483344968d4c93cd01f
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•6 years ago
|
||
Update to apply cleanly on inbound after the js-internal file moves. Carrying r+.
Attachment #8950220 -
Attachment is obsolete: true
Attachment #8951024 -
Flags: review+
|
|
Assignee | |
Comment 5•6 years ago
|
||
Try to verify it's still building: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95bd9e607b3b707d6da17a7be218a3f11efbf07f
|
||
Comment 6•6 years ago
|
||
This got bitrotted at least by bug 1437978, please provide an updated patch.
Flags: needinfo?(andrebargull)
Keywords: checkin-needed
|
|
Assignee | |
Comment 7•6 years ago
|
||
Rebased to apply on inbound. Carrying r+.
Attachment #8951024 -
Attachment is obsolete: true
Flags: needinfo?(andrebargull)
Attachment #8952150 -
Flags: review+
|
|
Assignee | |
Comment 8•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=80ec477de3676e9d92293c70f1f9221bd569b6b4
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9929099d4c41 Cache template literal objects per call site again. r=arai
Keywords: checkin-needed
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9929099d4c41
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•