Closed Bug 1437550 Opened 4 years ago Closed 4 years ago

[wpt-sync] PR 9480 - Fix hostnames


(Testing :: web-platform-tests, enhancement)

Not set


(firefox61 fixed)

Tracking Status
firefox61 --- fixed


(Reporter:, Unassigned)



(Whiteboard: [wptsync downstream error])

I believe there was an error in gh-8614. Since it removed the `hosts` property, [the templated `config.json` file which referenced that property]( can no longer be [expanded]( Here's an example of the error I encountered when running `./wpt run chrome` locally:

    Traceback (most recent call last):
      File "./wpt", line 5, in <module>
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wpt/", line 132, in main
        rv = script(*args, **kwargs)
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wpt/", line 419, in run
        rv = run_single(venv, **kwargs) > 0
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wpt/", line 426, in run_single
        return wptrunner.start(**kwargs)
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wptrunner/wptrunner/", line 295, in start
        return not run_tests(**kwargs)
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wptrunner/wptrunner/", line 185, in run_tests
        env_extras) as test_environment:
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wptrunner/wptrunner/", line 96, in __enter__
        self.config = self.load_config()
      File "/home/mike/projects/bocoup/google-wpt/web-platform-tests/tools/wptrunner/wptrunner/", line 132, in load_config
        local_config = json.loads(data % self.options)
    KeyError: 'host'

This hasn't interrupted things on CI because [the Firefox configuration object still includes the `hosts`
property](, and the builds for the effected browsers are configured as "allowed failures". [Those builds have recently been failing for this same reason](

The value in the Firefox configuration (``) differs from the value shared by all other browsers (`web-platform.test`). gh-8614 is fairly clear in its goal to reduce variability, so I'm assuming this disparity is not necessary/desirable. Since I can't think of any reason why the host should be different for Firefox, I've authored the patch to normalize on `web-platform.test`). If I'm wrong about that, then we can omit the second commit on this branch and apply only the first commit (which reverts the
original change).
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by
[wpt PR 9480] - Fix hostnames, a=testonly
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.