1437580 - Search engine name sent to telemetry is inconsistent

Status: RESOLVED WORKSFORME

(Firefox :: Search, enhancement, P5)

Description

[Mike Kaply [:mkaply]]

We currently send the search engine name to telemetry in four different places and we create the name inconsistently.

https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#3844
is used by
https://searchfox.org/mozilla-central/source/browser/base/content/browser.js#3896

https://searchfox.org/mozilla-central/source/browser/modules/BrowserUsageTelemetry.jsm#108
is used by
https://searchfox.org/mozilla-central/source/browser/modules/BrowserUsageTelemetry.jsm#407

https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/TelemetryEnvironment.jsm#1188
is used by
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/TelemetryEnvironment.jsm#1230 (marked deprecated in the docs, but we still use it.)

https://searchfox.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#4159
is used by
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/TelemetryEnvironment.jsm#1231


We should have a consistent API for querying the engine name from the search service (including other- with a completely definition of when to use other)

No one should be generating their own ID.

And we need to figure out why defaultSearchEngine was marked deprecated. We're still using it and it contains different data than defaultSearchEngineData.name (it doesn't contain the other- part).

Comment 1

[Drew Willcoxon :adw]

This doesn't seem super high priority, so I'll mark it P5, but please feel free to change it.

Comment 2

[Mark Banner (:standard8) (afk until 21st July)]

Unfortunately the links are all busted, but I'm pretty sure we're as consistent as we can be now.