1437582 - Intermittent browser/components/extensions/test/browser/browser_ext_tabs_lazy.js | Uncaught exception - [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]" nsresult: "0x80520015

Status: RESOLVED INCOMPLETE

(WebExtensions :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=161712772&repo=autoland

https://queue.taskcluster.net/v1/task/HLq8VoTXS16l0KaR6XdmhA/runs/0/artifacts/public/test_info/browser-chrome-chunked_errorsummary.log

Comment 1

[Intermittent Failures Robot]

17 failures in 139 pushes (0.122 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 12
* mozilla-inbound: 3
* mozilla-central: 2

Platform breakdown:
* windows7-32: 9
* windows10-64: 7
* linux32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1437582&startday=2018-02-14&endday=2018-02-14&tree=all

Comment 2

[Cristina Coroiu [:ccoroiu]]

Since this bug was created, 3 days ago, there are 39 failures. 
:ddurst could you please take a look?

Comment 3

[Intermittent Failures Robot]

17 failures in 149 pushes (0.114 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* autoland: 11
* mozilla-inbound: 3
* mozilla-central: 3

Platform breakdown:
* windows7-32: 12
* windows10-64: 3
* windows10-64-ccov: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1437582&startday=2018-02-15&endday=2018-02-15&tree=all

Comment 4

[Intermittent Failures Robot]

87 failures in 685 pushes (0.127 failures/push) were associated with this bug in the last 7 days. 

This is the #8 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **   

Repository breakdown:
* autoland: 39
* mozilla-central: 25
* mozilla-inbound: 22
* try: 1

Platform breakdown:
* windows7-32: 48
* windows10-64: 28
* windows10-64-ccov: 8
* windows10-64-nightly: 2
* linux32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1437582&startday=2018-02-12&endday=2018-02-18&tree=all

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm taking a look at this.

It seems that this test has started to have an higher frequency of failures related to the nsIFile.createUnique error (tracked by Bug 1435100) as soon as the test that was usually executed before this one (browser_ext_tabs_lastAccessed.js) has been disabled in Bug 1434590 (https://hg.mozilla.org/mozilla-central/rev/ce3478941993) one week ago.

Last week I tried to reproduce the underlying issue (Bug 1435100) locally on a Window 10 system, and I've been able to reproduce the failure often enough by running './mach mochitest --verify' on the 'browser_ext_tabs_insertCSS.js' test file, and that test file is executed exactly before 'browser_ext_tabs_lazy.js' (and it used to be executed before browser_ext_tabs_lastAccessed.js, before Bug 1434590's patch skipped it on windows).

And so I suspect that the test that is actually triggering this failure is browser_ext_tabs_insertCSS.js,
in particular my suspect is that the cached stylesheet (injected using tabs.insertCSS with an extension url)
is preventing the generated xpi file to be removed, and the test executed after that is going to fail on
nsIFile.createUnique (because nsIFile.createUnique tries to open the previously generated xpi file which is still locked
and it raises the NS_ERROR_FILE_ACCESS_DENIED error on windows).

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Yesterday we landed the patch from Bug 1435100, which we expect to fix the multiple intermittents that are frequently failing for timeout reasons (because of the NS_ERROR_FILE_ACCESS_DENIED error raised by nsIFile.createUnique when the test helpers are creating the generated xpi for the test extension defined in the test case).

We expect that the fix landed by Bug 1435100 should have fixed the frequent intermittency of this test.

I'm adding myself as the assignee on this issue so that it is visible that we are working on it.

Comment 7

[Intermittent Failures Robot]

35 failures in 675 pushes (0.052 failures/push) were associated with this bug in the last 7 days. 

This is the #37 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 13
* autoland: 10
* mozilla-central: 9
* try: 3

Platform breakdown:
* windows7-32: 22
* windows10-64: 11
* windows10-64-nightly: 1
* windows10-64-ccov: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1437582&startday=2018-02-19&endday=2018-02-25&tree=all

Comment 8

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup