Closed Bug 1437599 Opened 2 years ago Closed 2 years ago

Build warning: nsFrame.cpp:1903:10: warning: 'return' will never be executed [-Wunreachable-code-return]

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I noticed this build warning locally (with a clang trunk build, version 7.0):

> layout/generic/nsFrame.cpp:1903:10: warning: 'return' will never
>   be executed [-Wunreachable-code-return]

This is for a "return" after a switch statement that covers all possibilities (including a "default" case), whose case statements all say "return":
https://hg.mozilla.org/mozilla-central/rev/124fbb4b9a97#l3.9

Marking as having been introduced by bug 1336905, since that's where we added the "default" case that made the after-the-switch return statement unreachable.
Comment on attachment 8950283 [details]
Bug 1437599: Remove unreachable 'return' statement from nsIFrame::GetShapeBoxBorderRadii.

https://reviewboard.mozilla.org/r/219546/#review225300
Attachment #8950283 - Flags: review?(bwerth) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8e1fa44ff64
Remove unreachable 'return' statement from nsIFrame::GetShapeBoxBorderRadii. r=bradwerth
https://hg.mozilla.org/mozilla-central/rev/a8e1fa44ff64
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.