14376 - [PP] Click OK in File | Attach web page dialog results in crash

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[lchiang]

Click OK in File | Attach web page dialog results in crash

9/19 release build
Mac, OS 8.6

1) Messenger window
2) New message
3) File | Attach Web Page
4) Enter a URL in the dialog that appears.  For example, I entered:
http://www.sfgate.com
5) Click OK.
6) Crash occurs.  Stack trace from talkback report incident 13698912:

   0xffc10008
   nsMacEventHandler::HandleOSEvent()
[nsMacEventHandler.cpp, line 147]
   nsMacWindow::HandleOSEvent()
[nsMacWindow.cpp, line 710]
   nsMacMessageSink::DispatchOSEvent()
[nsMacMessageSink.cpp, line 40]
   nsMacMessagePump::DispatchOSEventToRaptor()
[nsMacMessagePump.cpp, line 802]
   nsMacMessagePump::DoMouseMove()
[nsMacMessagePump.cpp, line 663]
   nsMacMessagePump::DispatchEvent()
[nsMacMessagePump.cpp, line 317]
   nsMacMessagePump::DoMessagePump()
[nsMacMessagePump.cpp, line 230]
   nsAppShell::Run()
[nsAppShell.cpp, line 94]
   nsAppShellService::Run()
[nsAppShellService.cpp, line 460]
   main1()
[nsAppRunner.cpp, line 591]
   main()
[nsAppRunner.cpp, line 702]
   .__start

Comment 1

[Phil Peterson]

Reassign to ducarroz, TFV to M11, cc jefft

Comment 2

[pmock]

I can reproduce the problem in todays Mac seamonkey respin build
1999-09-20-12-m11.  It does not appear what url, you use.  I tried
http://www.netscape.com

Comment 3

[lchiang]

(target milestone is M11 or M12 - add to mail beta tracking bug)

Comment 4

[Jean-Francois Ducarroz]

With o build from this morning, I cannot event type a URL into the dialog box.
It crash every time I type the dot!

Comment 5

[Jean-Francois Ducarroz]

Ok, I fix the dot problem with Paul which was affecting every dialogs! Now I can
reproduce the crash... I am working on it.

Comment 6

[Jean-Francois Ducarroz]

It crash only if you don't put http:// at the beginning of the url:

http://www.sfgate.com is ok but www.sfgate.com crash!

Comment 7

[Jean-Francois Ducarroz]

Fixed and checked in. Support url without http://. Won't crash also anymore if url is invalid like asd://

www.apple.com, instead send will just fail.

Comment 8

[pmock]

Verified as fixed on win, mac, and linux.  As Jeff indicated, if the url is
missing the 'http://' or the url is typed incorrectly, the message will not be
sent.  It gives a stringid warning.

I was pleasantly surprised to see that typing "http://www.apple.com" or
"www.apple.com" correctly resolves url.  :)

ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/1999-11-15-21-M11/bac
kup/install.exe
ftp://sweetlou/products/client/seamonkey/macos/8.x/ppc/1999-11-16-12-M11/netscap
e5-mac-M11.sea.bin
ftp://sweetlou/products/client/seamonkey/unix/linux_glibc/2.2/x86/1999-11-15-20-
M11/netscape-i686-pc-linux-gnu.tar.gz

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f349a911fffb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14376: Use concept-menu with tab counter menu (https://github.com/mozilla-mobile/fenix/pull/14374)
https://hg.mozilla.org/integration/autoland/rev/4eab91721229
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14376: Reverse items with bottom toolbar (https://github.com/mozilla-mobile/fenix/pull/14451)