Add memory reporting for gNameToHistogramIDMap

RESOLVED FIXED in Firefox 60

Status

()

Toolkit
Telemetry
P1
normal
RESOLVED FIXED
11 days ago
9 days ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

(Whiteboard: [MemShrink])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 days ago
The base storage for this hashtable is unreported, and it is one of the larger unreported blocks of memory in DMD. Adding reporting for all of the related storage is probably tricky, but just reporting this one hashtable is trivial.

Unreported {
  1 block in heap block record 8 of 2,724
  131,072 bytes (131,072 requested / 0 slop)
  0.52% of the heap (18.66% cumulative)
  1.41% of unreported (50.65% cumulative)
  Allocated at {
    #01: PLDHashTable::Add(void const*, std::nothrow_t const&) (/media/ssd/mc/xpcom/ds/PLDHashTable.cpp:558)
    #02: nsTHashtable<nsBaseHashtableET<nsCStringHashKey, mozilla::Telemetry::HistogramID> >::PutEntry(nsTSubstring<char> const&, std::nothrow_t const&) (/media/ssd/mc/obj-dmd.noindex/dist/include/nsTHashtable.h:165)
    #03: nsBaseHashtable<nsCStringHashKey, mozilla::Telemetry::HistogramID, mozilla::Telemetry::HistogramID>::Put(nsTSubstring<char> const&, mozilla::Telemetry::HistogramID&&, std::nothrow_t const&) (/media/ssd/mc/obj-dmd.noindex/dist/include/nsBaseHashtable.h:169)
    #04: nsBaseHashtable<nsCStringHashKey, mozilla::Telemetry::HistogramID, mozilla::Telemetry::HistogramID>::Put(nsTSubstring<char> const&, mozilla::Telemetry::HistogramID&&) (/media/ssd/mc/obj-dmd.noindex/dist/include/nsBaseHashtable.h:162)
    #05: TelemetryHistogram::InitializeGlobalState(bool, bool) (/media/ssd/mc/toolkit/components/telemetry/TelemetryHistogram.cpp:1755)
    #06: (anonymous namespace)::TelemetryImpl::CreateTelemetryInstance() (/media/ssd/mc/toolkit/components/telemetry/Telemetry.cpp:1220)
    #07: (anonymous namespace)::nsITelemetryConstructor(nsISupports*, nsID const&, void**) (/media/ssd/mc/toolkit/components/telemetry/Telemetry.cpp:1601 (discriminator 2))
    #08: mozilla::GenericFactory::CreateInstance(nsISupports*, nsID const&, void**) (/media/ssd/mc/xpcom/components/GenericFactory.cpp:17)
  }
}
Comment hidden (mozreview-request)

Comment 2

10 days ago
mozreview-review
Comment on attachment 8950394 [details]
Bug 1437689 - Add basic memory reporting for gNameToHistogramIDMap.

https://reviewboard.mozilla.org/r/219614/#review225528

Thanks!
Attachment #8950394 - Flags: review?(gfritzsche) → review+
Priority: -- → P1

Comment 3

10 days ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fbcf450dfbaf
Add basic memory reporting for gNameToHistogramIDMap. r=gfritzsche

Comment 4

9 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fbcf450dfbaf
Status: NEW → RESOLVED
Last Resolved: 9 days ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.