1437699 - Expand Leanplum in other countries/locales for our Android users

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect, P1)

Description

[Jean Collings]

Expand LP to other countries at 100% (en_IN, en_ID, fr_FR, it_IT, id_ID, pt_BR, es_US, es_ES, es_MX, pl_PL and ru_RU)

Comment 1

[:sdaswani]

Jean, what release would you *like* to have this in?

Comment 2

[Jean Collings]

Does this change need to ride the trains? 

After Fx59 works for me if possible.

Comment 3

[:sdaswani]

Good question - I am not sure :) . I'll have to check and get back to you.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Product team would like this fixed in 60, tracked as blocking to ensure it's closely monitored.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Awaiting for LDAP and VPN as per https://wiki.mozilla.org/Mobile/Fennec/Android/Switchboard#Adding_a_new_experiment

Comment 6

[:sdaswani]

I think you can find VPN info here (requires LDAP): https://mana.mozilla.org/wiki/display/SD/VPN

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Currently on Fennec, LeanPlum is offered to English/Chinese/German global.

To allow targeting specific locales, language-country pairs, we need to do a slight modification in code.

Comment 8

[:sdaswani]

(In reply to Petru-Mugurel Lingurar[:petru] from comment #7)
> Currently on Fennec, LeanPlum is offered to English/Chinese/German global.
> 
> To allow targeting specific locales, language-country pairs, we need to do a
> slight modification in code.

That is what we expected Petru. Does switchboard need to be involved too?

Comment 9

[Petru-Mugurel Lingurar [:petru]]

(In reply to :sdaswani from comment #8)
> (In reply to Petru-Mugurel Lingurar[:petru] from comment #7)
> > Currently on Fennec, LeanPlum is offered to English/Chinese/German global.
> > 
> > To allow targeting specific locales, language-country pairs, we need to do a
> > slight modification in code.
> 
> That is what we expected Petru. Does switchboard need to be involved too?

On switchboard we do the updates, in the app will have to treat the updated cases.

Comment 10

[Petru-Mugurel Lingurar [:petru]]

To note: Because of current in-app implementation - https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/switchboard/SwitchBoard.java#219 LeanPlum (and other experiments) can only be made available to a specific language/country/region. Not to a specific locale like "es_US"

In the current implementation (https://firefox.settings.services.mozilla.com/v1/buckets/fennec/collections/experiments/records) LeanPlum is only available to 50% of the users which have en global/zh global/de global on their devices.

As such, for the next implementations we could add in SwitchBoard a new property to check, "locale" which would allow checking [language code - country code] inside the apps and thus a deeper targeting of the devices. This would make it possible to only allow LeanPlum if the device has [Spanish-US] set as locale on the device, as opposed to es global.

But because this will only affect future versions of the app, either
- all previous versions of Fennec will remain to offer LeanPlum to the current global languages (en, ch, de) or
- we will have to update SwitchBoard to allow LeanPlum on [en, fr, it, id, pt, es, pl and ru] global.

So, if we are from now on to only offer LeanPlum for [language-country] locales we will end up with different LeanPlum availabilities depending on the Fennec version used.

Comment 11

[Jean Collings]

Which would allow for me to say:

Option 1: Language is English, no country selection (so everyone in the world with language in English will get a campaign)
Option 2: Language is English, country is United States 
Option 3: Language is French, country is France 
Option 4: Language is Italian, country is Italy

Comment 12

[:sdaswani]

Petru thanks for the info and the explanation on how to better target locales. Given I'd like this to land in 60, let's file another bug to add your locale targeting, and use the current system per Jean's options to close this bug.

I think that means making https://firefox.settings.services.mozilla.com/v1/buckets/fennec/collections/experiments/records 100, and then expanding the lang value to include all the languages Jean wants. That said, I don't see where to target specific countries? Is the 'regions' field also used for that?

Comment 13

[Petru-Mugurel Lingurar [:petru]]

After discussing with :sdaswani, :sebastian helped with pushing the changes needed for this ticket and also for bug 1411066 on SwitchBoard.

LeanPlum experiment is now available for all users (100%) which have set the language used on their device to be "eng|zho|deu|fra|ita|ind|por|spa|pol|rus" (global)

I will work on a solution that will allow targetting specific [language-country] locales in the future versions.

I hope this is ok Kat.

Comment 14

[:sdaswani]

Petru, thanks for flagging Kat on this. I would hold off on doing any implementation work until we hear from Kat / Marketing on whether this is still needed, especially now that we've rolled out to so many more countries. I will set up a meeting to determine this soon.

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1437699 - Expand Leanplum in other countries/locales for our Android users;

Added a new SwitchBoard check for locale [language_country] to allow for better targeting of specific SwitchBoard experiments.

Review commit: https://reviewboard.mozilla.org/r/236426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236426/

Comment 16

[Petru-Mugurel Lingurar [:petru]]

Mike, I've tested the recently pushed patch with this newly added Switchboard configuration option
> "locale":"en_[A-Z]{2}|zh_TW|de_DE|fr_FR|it_IT|id_ID|pt_BR|es_US|es_ES|es_MX|pl_PL|ru_RU",
(should allow targeting specific locales [language_country] pairs as per this ticket and as per bug 1411066)

and I think this is what we needed to allow for a more precise targeting of the users (as the tickets requested) while still maintaining the current behavior for the users of older apps. (for them the feature will be available for that languages used globally).

Comment 17

[Julien Cristau [:jcristau]]

It sounds like this is still in flux, and it's too late for any changes in 60, so clearing tracking.

Comment 18

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8967709 [details]
Bug 1437699 - Expand Leanplum in other countries/locales for our Android users;

Clearing review request: according to comment 14 we should wait on Kat to see if this is still needed. Please re-add my review request at this time if it's needed.

Comment 19

[Cherry]

We are good for the moment to have via language used on their device to be eng|zho|deu|fra|ita|ind|por|spa|pol|rus (global)

We can create a separate bug for the solution that will allow[language-country]locale targeting for the future.