Closed
Bug 1437739
Opened 6 years ago
Closed 6 years ago
Don't blacklist the entirety of the JS engine for the signed integer overflow sanitizer
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
decoder
:
review+
|
Details | Diff | Splinter Review |
jstests and jit-tests only report two runtime signed overflows (filed as bug 1437729 and bug 1437731), so the problem appears easily well corralled enough to not exclude the entire engine from testing of this sort. I've had this patch locally for a week or so now to see what the lay of the land is, and it looks pretty clean. Would be really nice to get it out of my tree, because every time I qpush/qpop it I have to do more or less a clobber.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8950457 -
Flags: review?(choller)
|
||
Updated•6 years ago
|
Attachment #8950457 -
Flags: review?(choller) → review+
Pushed by jwalden@mit.edu: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4d38e826db Don't blacklist the entirety of the JS engine for the signed integer overflow sanitizer. jstests and jit-tests only report two runtime signed overflows, so the problem appears easily well corralled enough to not exclude the entire engine. r=decoder
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d4d38e826db
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in
before you can comment on or make changes to this bug.
Description
•