Closed Bug 1437790 Opened 2 years ago Closed 2 years ago

stylo-chrome: panicked at 'Resolving style on <image class="toolbarbutton-icon"> without current styles' on test_bug437844.xul

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: xidorn, Assigned: emilio)

References

Details

Attachments

(1 file)

thread '<unnamed>' panicked at 'Resolving style on <image class="toolbarbutton-icon"> (0x17ccc123940) without current styles: ElementData { styles: ElementStyles { primary: Some(Some(StrongRuleNode { p: 0x17cce2af2e0 })), pseudos: EagerPseudoStyles(None) }, damage: GeckoRestyleDamage(nsChangeHint(0)), hint: RESTYLE_SELF, flags: (empty) }'
So I took a look at this, and the restyle hint comes from the document state invalidation. Now, we need to figure out why that element wasn't processed during the restyle...
Oh, and the answer is easy, there's never a restyle...
Assignee: nobody → emilio
Comment on attachment 8950519 [details]
Bug 1437790: No need to reframe synchronously on chrome-flush-skin-caches.

https://reviewboard.mozilla.org/r/219798/#review225818

So the reframe was initially introduced in bug 252703 to workaround theme switch issue. It sounds like nothing really depends on a synchronous reframe, so posting a restyle event to ensure the frames get reframed eventually should be enough.

r=me with the comment addressed.

::: layout/base/PresShell.cpp:9271
(Diff revision 1)
> -WalkFramesThroughPlaceholders(nsPresContext *aPresContext, nsIFrame *aFrame,
> +WalkFramesThroughPlaceholders(nsPresContext* aPresContext, nsIFrame *aFrame,
>                                frameWalkerFn aFunc, void *aClosure)

I think you can drop the `aClosure` from here and `frameWalkerFn` completely now given nobody uses it anymore.
Attachment #8950519 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8950519 [details]
Bug 1437790: No need to reframe synchronously on chrome-flush-skin-caches.

https://reviewboard.mozilla.org/r/219798/#review225818

> I think you can drop the `aClosure` from here and `frameWalkerFn` completely now given nobody uses it anymore.

Yup! done.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/36480ec73c27
No need to reframe synchronously on chrome-flush-skin-caches. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/36480ec73c27
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.