1437802 - Create selectNodeText(node) in new web console test head.js

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

In order to focus a node in the web console the input must first be blurred or we will autofocus the input again.

To help with this we should have two helper functions:
devtools/client/webconsole/new-console-output/test/mochitest/head.js::selectNodeText(node)
devtools/client/webconsole/new-console-output/test/mochitest/head.js::isNodeSelected(node)

We should use this in current tests that use selection.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We never actually select a node in bug 1404359 so it isn't a dependency.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We don't need isNodeSelected() because it is a one liner anyhow: `selection.containsNode(node)`

I have added `selectNodeText(hud, node)` to `devtools/client/webconsole/new-console-output/test/mochitest/head.js`.

The two tests that select nodes now use this helper:

- devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_output_copy_newlines.js
- devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_output_copy.js

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437802 - Create selectNodeText(node) in new web console test head.js

Review commit: https://reviewboard.mozilla.org/r/219832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219832/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8950550 [details]
Bug 1437802 - Create selectNodeText(node) in new web console test head.js

https://reviewboard.mozilla.org/r/219832/#review225604

Looks good to me. r+ with a green TRY

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7398b884c9eb
Create selectNodeText(node) in new web console test head.js r=nchevobbe

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7398b884c9eb