Closed
Bug 1437807
Opened 7 years ago
Closed 7 years ago
Enable browser_console_addonsdk_loader_exception.js in new frontend
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: miker)
References
Details
(Whiteboard: [newconsole-mvp])
Attachments
(1 file)
No description provided.
|
Reporter | |
Updated•7 years ago
|
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Priority: -- → P2
Whiteboard: [newconsole-mvp]
|
||
Updated•7 years ago
|
Severity: normal → enhancement
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Depends on: 1437844
OS: Unspecified → All
Priority: P2 → P1
Hardware: Unspecified → All
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8956070 [details]
Bug 1437807 - Enable browser_console_addonsdk_loader_exception.js in new frontend
https://reviewboard.mozilla.org/r/225012/#review231234
Looks good Mike, thanks.
The runtime on debug builds seems to be around 10-15 seconds, so removing the requestLongerTimeout as you did should be fine.
::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_addonsdk_loader_exception.js:8
(Diff revision 2)
> /* Any copyright is dedicated to the Public Domain.
> * http://creativecommons.org/publicdomain/zero/1.0/ */
>
> /* import-globals-from head.js */
>
> // Check that exceptions from scripts loaded with the addon-sdk loader are
The addon-sdk loader was completely copied over to devtools, so "addon-sdk loader" will make less and less sense in the future.
Should we file a follow up to rename everything that refers to addonsdk loader (including the test name) to devtools loader?
Attachment #8956070 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> The addon-sdk loader was completely copied over to devtools, so "addon-sdk
> loader" will make less and less sense in the future.
> Should we file a follow up to rename everything that refers to addonsdk
> loader (including the test name) to devtools loader?
Bug 1443457 logged.
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c132fa7abc4b
Enable browser_console_addonsdk_loader_exception.js in new frontend r=jdescottes
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•