Closed Bug 1437807 Opened 2 years ago Closed 2 years ago
_console _addonsdk _loader _exception .js in new frontend
59 bytes, text/x-review-board-request
No description provided.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Priority: -- → P2
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Depends on: 1437844
OS: Unspecified → All
Priority: P2 → P1
Hardware: Unspecified → All
Depends on: 1442602
Depends on: 1442680
No longer blocks: 1443163
Depends on: 1443163
Comment on attachment 8956070 [details] Bug 1437807 - Enable browser_console_addonsdk_loader_exception.js in new frontend https://reviewboard.mozilla.org/r/225012/#review231234 Looks good Mike, thanks. The runtime on debug builds seems to be around 10-15 seconds, so removing the requestLongerTimeout as you did should be fine. ::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_addonsdk_loader_exception.js:8 (Diff revision 2) > /* Any copyright is dedicated to the Public Domain. > * http://creativecommons.org/publicdomain/zero/1.0/ */ > > /* import-globals-from head.js */ > > // Check that exceptions from scripts loaded with the addon-sdk loader are The addon-sdk loader was completely copied over to devtools, so "addon-sdk loader" will make less and less sense in the future. Should we file a follow up to rename everything that refers to addonsdk loader (including the test name) to devtools loader?
Attachment #8956070 - Flags: review?(jdescottes) → review+
(In reply to Julian Descottes [:jdescottes][:julian] from comment #3) > The addon-sdk loader was completely copied over to devtools, so "addon-sdk > loader" will make less and less sense in the future. > Should we file a follow up to rename everything that refers to addonsdk > loader (including the test name) to devtools loader? Bug 1443457 logged.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c132fa7abc4b Enable browser_console_addonsdk_loader_exception.js in new frontend r=jdescottes
You need to log in before you can comment on or make changes to this bug.