1437838 - Narrate module should listen to keydown event instead of keypress event

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We'll stop dispatching keypress events of non-printable key combinations and narrate module handles only non-printable keys without actual web pages. Therefore, it can change all keypress event listeners to keydown event listeners simply.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e931888af4b908021dc8bb96bbf8d1e232274051

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1437838 - Narrate module should listen to keydown events instead of keypress events

Looks like that any script of web pages don't run in reader mode.  If so,
it's safe narrate module to listen to keydown events of non-printable keys
because nobody listens to following keypress events of them.  So, it's OK
to stop dispatching following keypress event of keys handled by keydown
event handlers of narrate module.

Review commit: https://reviewboard.mozilla.org/r/220124/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220124/

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8950877 [details]
Bug 1437838 - Narrate module should listen to keydown events instead of keypress events

https://reviewboard.mozilla.org/r/220124/#review227630

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ded66b373f9
Narrate module should listen to keydown events instead of keypress events r=eeejay

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0ded66b373f9