Closed Bug 1437838 Opened 5 years ago Closed 5 years ago

Narrate module should listen to keydown event instead of keypress event

Categories

(Toolkit :: Reader Mode, enhancement)

Product:
Toolkit
Component:
Reader Mode
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

Bug 1437838 - Narrate module should listen to keydown events instead of keypress events
59 bytes, text/x-review-board-request
eeejay
: review+
Details 
We'll stop dispatching keypress events of non-printable key combinations and narrate module handles only non-printable keys without actual web pages. Therefore, it can change all keypress event listeners to keydown event listeners simply.
Summary: Narrate module should listen keydown event instead of keypress event → Narrate module should listen to keydown event instead of keypress event
Comment on attachment 8950877 [details]
Bug 1437838 - Narrate module should listen to keydown events instead of keypress events

https://reviewboard.mozilla.org/r/220124/#review227630

Thanks!
Attachment #8950877 - Flags: review?(eitan) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/0ded66b373f9
Narrate module should listen to keydown events instead of keypress events r=eeejay
https://hg.mozilla.org/mozilla-central/rev/0ded66b373f9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.