1437844 - Enable browser_console_consolejsm_output.js in new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437844 - Enable browser_console_consolejsm_output.js in new frontend

The old test was focused on log levels so I have converted this to use categories as discussed.

Of course, the test passes just fine with `verify`

Review commit: https://reviewboard.mozilla.org/r/224352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/224352/

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955193 [details]
Bug 1437844 - Enable browser_console_consolejsm_output.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224352/diff/1-2/

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955193 [details]
Bug 1437844 - Enable browser_console_consolejsm_output.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224352/diff/2-3/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8955193 [details]
Bug 1437844 - Enable browser_console_consolejsm_output.js in new frontend

https://reviewboard.mozilla.org/r/224352/#review230590

Thanks Mike, looks a lot better now :)

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_consolejsm_output.js:75
(Diff revision 3)
> -  let {ConsoleAPI} = ChromeUtils.import("resource://gre/modules/Console.jsm", {});
> -  let consoleOptions = {
> -    maxLogLevel: "error",
> -    maxLogLevelPref: "testing.maxLogLevel",
> -  };
> +  console2.error(shouldBeVisible);
> +  console2.log(shouldBeHidden);
> +
> +  await checkMessageExists(hud, shouldBeVisible);
> +  await checkMessageHidden(hud, shouldBeHidden);

could we invert the calls so we are sure that the "should be hidden" message is indeed hidden (as opposed to "pending to be rendered")

```js
onsole2.log(shouldBeHidden);
console2.error(shouldBeVisible);

await checkMessageExists(hud, shouldBeVisible);
// Here we can safely assert that the log message is not visible, since the error message was logged after and is visible.
await checkMessageHidden(hud, shouldBeHidden);
```

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_consolejsm_output.js:131
(Diff revision 3)
> +  ok(message, `"${msg}" was logged`);
> +}
> +
> +async function checkMessageHidden(hud, msg) {
> +  info(`Checking "${msg}" was not logged`);
> +  await waitFor(() => findMessages(hud, msg).length === 0);

nit: maybe we could use `findMessage(msg) === null` ?

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955193 [details]
Bug 1437844 - Enable browser_console_consolejsm_output.js in new frontend

https://reviewboard.mozilla.org/r/224352/#review230590

> nit: maybe we could use `findMessage(msg) === null` ?

It returns `undefined` so in the end I went with `findMessage(hud, msg) == null`

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8955193 [details]
Bug 1437844 - Enable browser_console_consolejsm_output.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/224352/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7b3c610cbca
Enable browser_console_consolejsm_output.js in new frontend r=nchevobbe

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b7b3c610cbca