1437847 - Enable browser_console_error_source_click.js in new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437847 - Enable browser_console_error_source_click.js in new frontend

Review commit: https://reviewboard.mozilla.org/r/223882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/223882/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8954745 [details]
Bug 1437847 - Enable browser_console_error_source_click.js in new frontend

https://reviewboard.mozilla.org/r/223882/#review230186

Thanks Mike, looks good! Just one small comment + a nit.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_error_source_click.js:22
(Diff revision 1)
> -
> -  yield loadTab(TEST_URI);
> -  let hud = yield HUDService.toggleBrowserConsole();
>    ok(hud, "browser console opened");
>  
> +  setFilterState(hud, {

setFilterState is async, could we add await here? Also add a small info right before to explain what this is doing.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_error_source_click.js:50
(Diff revision 1)
> -  let viewSourceCalled = false;
> +async function waitForMessageAndViewSource(hud, message) {
> +  let msg = await waitFor(() => findMessage(hud, message));
> +  ok(msg, `Message found: "${message}"`);
>  
> -  let viewSource = hud.viewSource;
> -  hud.viewSource = () => {
> +  let locationNode = msg.querySelector(".message-location .frame-link-source");
> +  ok(locationNode, "location node");

nit: could use a clearer assert message? "Message location link element found" ?

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8954745 [details]
Bug 1437847 - Enable browser_console_error_source_click.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/223882/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce41e79ade93
Enable browser_console_error_source_click.js in new frontend r=jdescottes

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ce41e79ade93