Closed Bug 1437847 Opened 4 years ago Closed 4 years ago

Enable browser_console_error_source_click.js in new frontend

Categories

(DevTools :: Console, enhancement, P1)

Product:
DevTools
Component:
Console
Type:
enhancement

Tracking

(firefox60 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: miker)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

Bug 1437847 - Enable browser_console_error_source_click.js in new frontend
59 bytes, text/x-review-board-request
jdescottes
: review+
Details 
No description provided.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Priority: -- → P2
Whiteboard: [newconsole-mvp]
Severity: normal → enhancement
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: P2 → P1
Hardware: Unspecified → All
Comment on attachment 8954745 [details]
Bug 1437847 - Enable browser_console_error_source_click.js in new frontend

https://reviewboard.mozilla.org/r/223882/#review230186

Thanks Mike, looks good! Just one small comment + a nit.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_error_source_click.js:22
(Diff revision 1)
> -
> -  yield loadTab(TEST_URI);
> -  let hud = yield HUDService.toggleBrowserConsole();
>    ok(hud, "browser console opened");
>  
> +  setFilterState(hud, {

setFilterState is async, could we add await here? Also add a small info right before to explain what this is doing.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_error_source_click.js:50
(Diff revision 1)
> -  let viewSourceCalled = false;
> +async function waitForMessageAndViewSource(hud, message) {
> +  let msg = await waitFor(() => findMessage(hud, message));
> +  ok(msg, `Message found: "${message}"`);
>  
> -  let viewSource = hud.viewSource;
> -  hud.viewSource = () => {
> +  let locationNode = msg.querySelector(".message-location .frame-link-source");
> +  ok(locationNode, "location node");

nit: could use a clearer assert message? "Message location link element found" ?
Attachment #8954745 - Flags: review?(jdescottes) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce41e79ade93
Enable browser_console_error_source_click.js in new frontend r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/ce41e79ade93
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.