Closed
Bug 1437849
Opened 6 years ago
Closed 6 years ago
Enable browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js in new frontend
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: miker)
References
Details
(Whiteboard: [newconsole-mvp])
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•6 years ago
|
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Priority: -- → P2
Whiteboard: [newconsole-mvp]
Updated•6 years ago
|
Severity: normal → enhancement
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: P2 → P1
Hardware: Unspecified → All
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8951225 [details] Bug 1437849 - Enable browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js in new frontend https://reviewboard.mozilla.org/r/220492/#review227204 Please rename the test file to something like: browser_jsterm_hide_when_devtools_chrome_enabled_false.js ... so, it's nicely groupped with other jsterm related tests. Green when running locally on Win10 R+ assuming try is also green Thanks, Honza ::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js:97 (Diff revision 1) > + let arrow = objInspector.querySelector(".arrow"); > + arrow.click(); > + await onMutation; > + > + ok(arrow.classList.contains("expanded"), > + "The arrow of the root node of the tree is expanded after clicking on it"); nit: Fix indentation
Attachment #8951225 -
Flags: review?(odvarko) → review+
Comment hidden (mozreview-request) |
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8ed76de9d7eb Enable browser_console_hide_jsterm_when_devtools_chrome_enabled_false.js in new frontend r=Honza
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ed76de9d7eb
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•