1437851 - Enable browser_console_open_or_focus.js in new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

Review commit: https://reviewboard.mozilla.org/r/220218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220218/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8950955 [details]
Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

https://reviewboard.mozilla.org/r/220218/#review226452

I think you tested this against the old frontend enabled for the browser console.

You need to first rebase this patch on top of https://bugzilla.mozilla.org/show_bug.cgi?id=1437856 (latest central is good enough)
The test currently fails after rebase with the following error occurring twice:

  TEST-UNEXPECTED-FAIL | devtools/client/webconsole/new-console-output/test/mochitest/browser_console_open_or_focus.js | The Browser Console is open and has focus - Got chrome://devtools/content/webconsole/browserconsole.xul, expected chrome://devtools/content/webconsole/webconsole.xul
 
I think you just need to swap Tools.webConsole.oldWebConsoleURL with Tools.webConsole.browserConsoleURL here. Can you rebase and check it works with the new frontend?

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_open_or_focus.js:13
(Diff revision 1)
>  // Test that the "browser console" menu item opens or focuses (if already open)
>  // the console window instead of toggling it open/close.
>  
>  "use strict";
>  
> -var {Tools} = require("devtools/client/definitions");
> +const test_message = "testmessage";

nit: uppercase? TEST_MESSAGE

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_open_or_focus.js:14
(Diff revision 1)
>  // the console window instead of toggling it open/close.
>  
>  "use strict";
>  
> -var {Tools} = require("devtools/client/definitions");
> +const test_message = "testmessage";
> +var { Tools } = require("devtools/client/definitions");

nit: var -> const

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8950955 [details]
Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220218/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8950955 [details]
Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

https://reviewboard.mozilla.org/r/220218/#review228392

Looks good to me, thanks Mike!

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8950955 [details]
Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220218/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/770b1ed74e15
Enable browser_console_open_or_focus.js in new frontend r=jdescottes

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/770b1ed74e15