Closed Bug 1437851 Opened 4 years ago Closed 4 years ago

Enable browser_console_open_or_focus.js in new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: miker)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
Priority: -- → P2
Whiteboard: [newconsole-mvp]
Severity: normal → enhancement
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: P2 → P1
Hardware: Unspecified → All
Comment on attachment 8950955 [details]
Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

https://reviewboard.mozilla.org/r/220218/#review226452

I think you tested this against the old frontend enabled for the browser console.

You need to first rebase this patch on top of https://bugzilla.mozilla.org/show_bug.cgi?id=1437856 (latest central is good enough)
The test currently fails after rebase with the following error occurring twice:

  TEST-UNEXPECTED-FAIL | devtools/client/webconsole/new-console-output/test/mochitest/browser_console_open_or_focus.js | The Browser Console is open and has focus - Got chrome://devtools/content/webconsole/browserconsole.xul, expected chrome://devtools/content/webconsole/webconsole.xul
 
I think you just need to swap Tools.webConsole.oldWebConsoleURL with Tools.webConsole.browserConsoleURL here. Can you rebase and check it works with the new frontend?

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_open_or_focus.js:13
(Diff revision 1)
>  // Test that the "browser console" menu item opens or focuses (if already open)
>  // the console window instead of toggling it open/close.
>  
>  "use strict";
>  
> -var {Tools} = require("devtools/client/definitions");
> +const test_message = "testmessage";

nit: uppercase? TEST_MESSAGE

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_console_open_or_focus.js:14
(Diff revision 1)
>  // the console window instead of toggling it open/close.
>  
>  "use strict";
>  
> -var {Tools} = require("devtools/client/definitions");
> +const test_message = "testmessage";
> +var { Tools } = require("devtools/client/definitions");

nit: var -> const
Attachment #8950955 - Flags: review?(jdescottes)
Comment on attachment 8950955 [details]
Bug 1437851 - Enable browser_console_open_or_focus.js in new frontend

https://reviewboard.mozilla.org/r/220218/#review228392

Looks good to me, thanks Mike!
Attachment #8950955 - Flags: review?(jdescottes) → review+
No longer depends on: 1437854
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/770b1ed74e15
Enable browser_console_open_or_focus.js in new frontend r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/770b1ed74e15
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.