1437854 - Enable browser_console_webconsole_ctrlw_close_tab.js in new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1437854 - Enable browser_console_webconsole_ctrlw_close_tab.js in new frontend

Review commit: https://reviewboard.mozilla.org/r/220198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220198/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8950944 [details]
Bug 1437854 - Enable browser_console_webconsole_ctrlw_close_tab.js in new frontend

https://reviewboard.mozilla.org/r/220198/#review226810

The test fails for me on Win10

Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=ÔÇťrÔÇŁ modifiers=ÔÇťaccel,altÔÇŁ id=ÔÇťkey_toggleReaderModeÔÇŁ" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 920}]
Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=ÔÇťrÔÇŁ modifiers=ÔÇťaccel,altÔÇŁ id=ÔÇťkey_quickRestartÔÇŁ" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 920}]
Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key=ÔÇťiÔÇŁ modifiers=ÔÇťaccel,alt,shiftÔÇŁ id=ÔÇťkey_browserToolboxÔÇŁ" {file: "chrome://mochikit/content/tests/SimpleTest/EventUtils.js" line: 920}]
toolbox destroyed
promise.all resolved. start testing the Browser Console
Console message: [JavaScript Warning: "Unknown property ÔÇśuser-selectÔÇÖ.  Declaration dropped." {file: "resource://devtools/client/shared/components/reps/reps.css" line: 257 column: 13 source: "  user-select: none;"}]
TEST-PASS | devtools/client/webconsole/new-console-output/test/mochitest/browser_console_webconsole_ctrlw_close_tab.js | Browser Console opened -
must wait for focus
Console message: [JavaScript Warning: "The Web Console logging API (console.log, console.info, console.warn, console.error) has been disabled by a script on this page."]
runtests.py | Received keyboard interrupt.


Honza

Comment 3

[Julian Descottes [:jdescottes]]

I think Bug 1439371 is the blocker for this. Also it is mandatory to rebase on top of a recent central, including https://hg.mozilla.org/mozilla-central/rev/04ddbc05db87, otherwise the new console frontend is not used for those tests.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8950944 [details]
Bug 1437854 - Enable browser_console_webconsole_ctrlw_close_tab.js in new frontend

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/220198/diff/1-2/

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Review ping

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8950944 [details]
Bug 1437854 - Enable browser_console_webconsole_ctrlw_close_tab.js in new frontend

https://reviewboard.mozilla.org/r/220198/#review228976

Looks good to me and passes locally on my win10 machine.
Thanks Mike,
Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c0eef1ad232
Enable browser_console_webconsole_ctrlw_close_tab.js in new frontend r=Honza

Comment 8

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/0c0eef1ad232