1437876 - Remove JS_ARRAY_LENGTH and JS_ARRAY_END

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Jason Orendorff [:jorendorff]]

mozilla::ArrayLength() is better: it won't silently give a bogus answer if you pass it a non-array argument.

(Also, JS_ARRAY_LENGTH broke my patch, a capital offense. Really, "unified" builds are to blame, as usual, but since I can't murder them, JS_ARRAY_LENGTH gets it.)

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Remove JS_ARRAY_LENGTH and JS_ARRAY_END

mozilla::ArrayLength() is better: it won't silently give a bogus answer if you
pass it a non-array argument.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8950624 [details] [diff] [review]
Remove JS_ARRAY_LENGTH and JS_ARRAY_END

Review of attachment 8950624 [details] [diff] [review]:
-----------------------------------------------------------------

Good riddance.

::: js/src/gc/AllocKind.h
@@ +189,5 @@
>          FOR_EACH_ALLOCKIND(DEFINE_NURSERY_ALLOCABLE)
>  #undef DEFINE_NURSERY_ALLOCABLE
>      };
>  
> +    static_assert(MOZ_ARRAY_LENGTH(map) == size_t(AllocKind::LIMIT),

Nit: mozilla::ArrayLength here and below?

Comment 3

[Jason Orendorff [:jorendorff]]

D'oh. Thanks.

Comment 4

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d7a22f4a198b0397c9540cdcc2fc3bfe8b5e3e2
Bug 1437876 - Remove JS_ARRAY_LENGTH and JS_ARRAY_END. r=jandem.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4d7a22f4a198