143791 - menuseparator in Go menu should stay hidden for tabbed mode

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[HJ]

mozilla RC2 on win32

Steps to reproduce:
1.start mozilla
2.activate tabbed browser mode (ctrl-t)
3.activate Go menu
note: second tab should be selected

current result:
second menuseparator is visible

expected result: last menuseparator should be hidden

I already made a small patch for this.

Comment 1

[HJ]

Attachment: diff -u from updated file sessionHistoryUI.js

Comment 2

[HJ]

Attachment: last filetype was wrong

Comment 3

[[e-mail]]

Attachment: Better patch

Comment 4

[HJ]

note: Hyatt told me (#mozilla) to 'remove' attributes set to 'false', and that's
not the case here.

Comment 5

[jag (Peter Annema)]

Comment on attachment 85737 [details] [diff] [review]
Better patch

>Index: sessionHistoryUI.js
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/sessionHistoryUI.js,v
>retrieving revision 1.41
>diff -u -r1.41 sessionHistoryUI.js
>--- sessionHistoryUI.js	6 Mar 2002 07:48:44 -0000	1.41
>+++ sessionHistoryUI.js	31 May 2002 07:57:00 -0000
>@@ -82,7 +82,7 @@
>             }
>           break;
>         case "go":
>-        if (count > 0) aParent.lastChild.removeAttribute( "hidden" );
>+          aParent.lastChild.hidden = !count;

I prefer |aParent.lastChild.hidden = (count == 0);|. Write what you mean (and
you don't mean to check if count is false).

sr=jag either way.

Comment 6

[[e-mail]]

HJ: .hidden = false is not the same as .setAttribute("hidden", "false")

Comment 7

[[e-mail]]

jag: sessionHistory.count attribute is of long type so can never be false...

Comment 8

[jag (Peter Annema)]

Neil: Isn't that what I said?

Comment 9

[[e-mail]]

> (and you don't mean to check if count is false).

But count can never be false (except in the 0 = false sense), it's a long int...

Anyway, timeless has checked in your version.

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed on all platforms with 2002.09.16.08 comm trunk builds.