menuseparator in Go menu should stay hidden for tabbed mode

VERIFIED FIXED

Status

--
trivial
VERIFIED FIXED
17 years ago
11 years ago

People

(Reporter: bugs4hj, Assigned: jag+mozilla)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

17 years ago
mozilla RC2 on win32

Steps to reproduce:
1.start mozilla
2.activate tabbed browser mode (ctrl-t)
3.activate Go menu
note: second tab should be selected

current result:
second menuseparator is visible

expected result: last menuseparator should be hidden

I already made a small patch for this.
(Reporter)

Comment 1

17 years ago
Created attachment 83226 [details]
diff -u from updated file sessionHistoryUI.js
(Reporter)

Comment 2

17 years ago
Created attachment 83227 [details] [diff] [review]
last filetype was wrong
Attachment #83226 - Attachment is obsolete: true
(Reporter)

Updated

17 years ago
Keywords: patch, review
(Reporter)

Comment 4

17 years ago
note: Hyatt told me (#mozilla) to 'remove' attributes set to 'false', and that's
not the case here.
(Assignee)

Comment 5

17 years ago
Comment on attachment 85737 [details] [diff] [review]
Better patch

>Index: sessionHistoryUI.js
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/sessionHistoryUI.js,v
>retrieving revision 1.41
>diff -u -r1.41 sessionHistoryUI.js
>--- sessionHistoryUI.js	6 Mar 2002 07:48:44 -0000	1.41
>+++ sessionHistoryUI.js	31 May 2002 07:57:00 -0000
>@@ -82,7 +82,7 @@
>             }
>           break;
>         case "go":
>-        if (count > 0) aParent.lastChild.removeAttribute( "hidden" );
>+          aParent.lastChild.hidden = !count;

I prefer |aParent.lastChild.hidden = (count == 0);|. Write what you mean (and
you don't mean to check if count is false).

sr=jag either way.
Attachment #85737 - Flags: superreview+
HJ: .hidden = false is not the same as .setAttribute("hidden", "false")
jag: sessionHistory.count attribute is of long type so can never be false...
(Assignee)

Comment 8

17 years ago
Neil: Isn't that what I said?

Updated

17 years ago
Attachment #85737 - Flags: review+
> (and you don't mean to check if count is false).

But count can never be false (except in the 0 = false sense), it's a long int...

Anyway, timeless has checked in your version.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
vrfy'd fixed on all platforms with 2002.09.16.08 comm trunk builds.
Status: RESOLVED → VERIFIED
OS: Windows NT → All
Hardware: PC → All
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.