Closed Bug 1437912 Opened 2 years ago Closed 2 years ago

[tryselect] mach try fuzzy <path> doesn't handle subsuites

Categories

(Testing :: General, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox60 fixed)

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(3 files)

This means that if you specify a path to e.g devtools, it will offer the browser-chrome tasks instead of the devtools-chrome ones.
Comment on attachment 8951318 [details]
Bug 1437912 - [moztest] Make TEST_SUITES aliases case insensitive,

https://reviewboard.mozilla.org/r/220564/#review226576

The simplification and improved consistency in case support is great!

I am personally not enthusiastic about the new browser-chrome, devtools-chrome and plain aliases. I won't use them, but I guess they are harmless.
Attachment #8951318 - Flags: review?(gbrown) → review+
Comment on attachment 8951320 [details]
Bug 1437912 - [moztest] Add some missing subsuite definitions,

https://reviewboard.mozilla.org/r/220568/#review226698
Attachment #8951320 - Flags: review?(gbrown) → review+
Comment on attachment 8951319 [details]
Bug 1437912 - [moztest] Map flavors and subsuites to a suite definition,

https://reviewboard.mozilla.org/r/220566/#review226582

This looks good to me (but I don't know this code well).

::: commit-message-c0112:13
(Diff revision 1)
> +data in TEST_SUITES), and instead provides two new private mappings:
> +
> +<flavor> -> suite definition
> +(<flavor>, <subsuite>) -> suite definition
> +
> +To find retrieve a suite definition given a flavor/subsuite, consumers can now

"To find retrieve"...something is wrong there.

::: tools/tryselect/selectors/fuzzy.py:217
(Diff revision 1)
>      all_tasks = generate_tasks(parameters, full, root=vcs.root)
>  
>      if paths:
>          all_tasks = filter_by_paths(all_tasks, paths)
> +        if not all_tasks:
> +            return

When will this happen? Should you print a warning or anything here?
Attachment #8951319 - Flags: review?(gbrown) → review+
Comment on attachment 8951319 [details]
Bug 1437912 - [moztest] Map flavors and subsuites to a suite definition,

https://reviewboard.mozilla.org/r/220566/#review226582

> When will this happen? Should you print a warning or anything here?

This will happen if none of the passed in paths could be resolved to a task. In this case, one or more "warning: no tasks could be resolved ..." messages above will already have been printed.

I guess we could print an additional error message, but I thought the warning(s) would be sufficient. I'll at least change it to return 1 to better reflect something went wrong.
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22bc43ba6870
[moztest] Make TEST_SUITES aliases case insensitive, r=gbrown
https://hg.mozilla.org/integration/autoland/rev/45810ed08842
[moztest] Map flavors and subsuites to a suite definition, r=gbrown
https://hg.mozilla.org/integration/autoland/rev/5d12c0ceb2a5
[moztest] Add some missing subsuite definitions, r=gbrown
https://hg.mozilla.org/mozilla-central/rev/22bc43ba6870
https://hg.mozilla.org/mozilla-central/rev/45810ed08842
https://hg.mozilla.org/mozilla-central/rev/5d12c0ceb2a5
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.